Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 19492006: Cleanup StringAddFlags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add extra ASSERTs. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3701 matching lines...) Expand 10 before | Expand all | Expand 10 after
3712 context()->Plug(result); 3712 context()->Plug(result);
3713 } 3713 }
3714 3714
3715 3715
3716 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 3716 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
3717 ZoneList<Expression*>* args = expr->arguments(); 3717 ZoneList<Expression*>* args = expr->arguments();
3718 ASSERT_EQ(2, args->length()); 3718 ASSERT_EQ(2, args->length());
3719 VisitForStackValue(args->at(0)); 3719 VisitForStackValue(args->at(0));
3720 VisitForStackValue(args->at(1)); 3720 VisitForStackValue(args->at(1));
3721 3721
3722 StringAddStub stub(NO_STRING_ADD_FLAGS); 3722 StringAddStub stub(STRING_ADD_CHECK_BOTH);
3723 __ CallStub(&stub); 3723 __ CallStub(&stub);
3724 context()->Plug(r0); 3724 context()->Plug(r0);
3725 } 3725 }
3726 3726
3727 3727
3728 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) { 3728 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) {
3729 ZoneList<Expression*>* args = expr->arguments(); 3729 ZoneList<Expression*>* args = expr->arguments();
3730 ASSERT_EQ(2, args->length()); 3730 ASSERT_EQ(2, args->length());
3731 VisitForStackValue(args->at(0)); 3731 VisitForStackValue(args->at(0));
3732 VisitForStackValue(args->at(1)); 3732 VisitForStackValue(args->at(1));
(...skipping 1180 matching lines...) Expand 10 before | Expand all | Expand 10 after
4913 *context_length = 0; 4913 *context_length = 0;
4914 return previous_; 4914 return previous_;
4915 } 4915 }
4916 4916
4917 4917
4918 #undef __ 4918 #undef __
4919 4919
4920 } } // namespace v8::internal 4920 } } // namespace v8::internal
4921 4921
4922 #endif // V8_TARGET_ARCH_ARM 4922 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698