gpu: Add flag for enabling asynchronous worker context.

gpu: Add flag for enabling asynchronous worker context.

Passing the --enable-gpu-async-worker-context causes the worker context
created by RenderThreadImpl to use a different GPU stream. This also
implies that the worker and compositor contexts cannot be in the same
share group. At the moment there is no extra synchronization between the
worker context and compositor context other than OrderingBarrier so
using this flag does not guarantee correct rendering.

R=piman@chromium.org,dcheng@chromium.org
BUG=525259
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d8ce1c2c02a0a77a8853ec1d0ced673fd77388a8
Cr-Commit-Position: refs/heads/master@{#392645}

[sunnyps, 2016-05-04 21:30:38]

Description was changed from

==========
gpu: Add flag for enabling asynchronous worker context.

Passing the --enable-gpu-async-worker-context causes the worker context
created by RenderThreadImpl to use a different GPU stream. This also
implies that the worker and compositor contexts cannot be in the same
share group. At the moment there is no extra synchronization between the
worker context and compositor context other than OrderingBarrier so
using this flag does not guarantee correct rendering.

R=piman@chromium.org,dcheng@chromium.org
BUG=525259
==========

to

==========
gpu: Add flag for enabling asynchronous worker context.

Passing the --enable-gpu-async-worker-context causes the worker context
created by RenderThreadImpl to use a different GPU stream. This also
implies that the worker and compositor contexts cannot be in the same
share group. At the moment there is no extra synchronization between the
worker context and compositor context other than OrderingBarrier so
using this flag does not guarantee correct rendering.

R=piman@chromium.org,dcheng@chromium.org
BUG=525259
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sunnyps, 2016-05-04 21:30:41]

Description was changed from

==========
gpu: Add flag for enabling asynchronous worker context.

Passing the --enable-gpu-async-worker-context causes the worker context
created by RenderThreadImpl to use a different GPU stream. This also
implies that the worker and compositor contexts cannot be in the same
share group. At the moment there is no extra synchronization between the
worker context and compositor context other than OrderingBarrier so
using this flag does not guarantee correct rendering.

R=piman@chromium.org,dcheng@chromium.org
BUG=525259
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Add flag for enabling asynchronous worker context.

Passing the --enable-gpu-async-worker-context causes the worker context
created by RenderThreadImpl to use a different GPU stream. This also
implies that the worker and compositor contexts cannot be in the same
share group. At the moment there is no extra synchronization between the
worker context and compositor context other than OrderingBarrier so
using this flag does not guarantee correct rendering.

R=piman@chromium.org,dcheng@chromium.org
BUG=525259
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunnyps, 2016-05-04 21:35:17]

PTAL

[sunnyps, 2016-05-04 21:36:33]

On 2016/05/04 21:35:17, sunnyps wrote:
> PTAL

dcheng@ Please RS gpu_stream_constants.h

[piman, 2016-05-04 21:39:35]

You are going to need to rebase on top of at least
https://codereview.chromium.org/1944603002 (merged
WebGraphicsContext3DCommandBufferImpl with ContextProviderCommandBuffer)

[piman, 2016-05-04 21:45:06]

https://codereview.chromium.org/1949023005/diff/20001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1949023005/diff/20001/content/renderer/render...
content/renderer/render_thread_impl.cc:1954:
switches::kEnableGpuAsyncWorkerContext)) {
For this to work, you need to propagate the flag to the renderer - see
RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer

[sunnyps, 2016-05-06 01:24:36]

sunnyps@chromium.org changed reviewers:
- dcheng@chromium.org

[sunnyps, 2016-05-06 01:24:37]

Rebased and also fixed the flag forwarding. PTAL

Also -dcheng since there are no changes to gpu_stream_constants any more -
realized that GPU_STREAM_INVALID was being used indirectly.

[piman, 2016-05-06 01:34:21]

lgtm

[sunnyps, 2016-05-06 04:47:28]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2016-05-06 04:47:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023005/100001

[commit-bot: I haz the power, 2016-05-06 04:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 04:49:48]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[sunnyps, 2016-05-07 02:33:53]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2016-05-07 02:33:53]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1949023005/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-07 02:34:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023005/120001

[commit-bot: I haz the power, 2016-05-07 02:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-07 02:42:42]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sunnyps, 2016-05-07 06:48:04]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2016-05-07 06:48:05]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1949023005/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-05-07 06:48:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023005/140001

[commit-bot: I haz the power, 2016-05-07 06:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-07 06:59:44]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[sunnyps, 2016-05-09 17:14:55]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2016-05-09 17:14:55]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1949023005/#ps160001
(title: " ")

[commit-bot: I haz the power, 2016-05-09 17:15:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023005/160001

[commit-bot: I haz the power, 2016-05-09 18:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:05:48]

Failed to apply patch for
content/browser/renderer_host/compositor_impl_android.cc:
While running git apply --index -3 -p1;
  error: patch failed:
content/browser/renderer_host/compositor_impl_android.cc:571
  Falling back to three-way merge...
  Applied patch to 'content/browser/renderer_host/compositor_impl_android.cc'
with conflicts.
  U content/browser/renderer_host/compositor_impl_android.cc

Patch:       content/browser/renderer_host/compositor_impl_android.cc
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc
b/content/browser/renderer_host/compositor_impl_android.cc
index
3c58174ed68cf624b779d748e15c8c3006ad35cb..06857ab76dd7469b002533c3210f901232e88d06
100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -571,7 +571,8 @@ void CompositorImpl::CreateOutputSurface() {
 
   scoped_refptr<ContextProviderCommandBuffer> context_provider(
       new ContextProviderCommandBuffer(
-          std::move(gpu_channel_host), surface_handle_, url,
+          std::move(gpu_channel_host), gpu::GPU_STREAM_DEFAULT,
+          gpu::GpuStreamPriority::NORMAL, surface_handle_, url,
           gfx::PreferIntegratedGpu, automatic_flushes, limits, attributes,
           nullptr,
           command_buffer_metrics::DISPLAY_COMPOSITOR_ONSCREEN_CONTEXT));

[sunnyps, 2016-05-10 17:06:17]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2016-05-10 17:06:17]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1949023005/#ps200001
(title: "rebase fix")

[commit-bot: I haz the power, 2016-05-10 17:07:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949023005/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949023005/200001

[commit-bot: I haz the power, 2016-05-10 18:02:56]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-05-10 18:05:25]

Description was changed from

==========
gpu: Add flag for enabling asynchronous worker context.

Passing the --enable-gpu-async-worker-context causes the worker context
created by RenderThreadImpl to use a different GPU stream. This also
implies that the worker and compositor contexts cannot be in the same
share group. At the moment there is no extra synchronization between the
worker context and compositor context other than OrderingBarrier so
using this flag does not guarantee correct rendering.

R=piman@chromium.org,dcheng@chromium.org
BUG=525259
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
gpu: Add flag for enabling asynchronous worker context.

Passing the --enable-gpu-async-worker-context causes the worker context
created by RenderThreadImpl to use a different GPU stream. This also
implies that the worker and compositor contexts cannot be in the same
share group. At the moment there is no extra synchronization between the
worker context and compositor context other than OrderingBarrier so
using this flag does not guarantee correct rendering.

R=piman@chromium.org,dcheng@chromium.org
BUG=525259
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d8ce1c2c02a0a77a8853ec1d0ced673fd77388a8
Cr-Commit-Position: refs/heads/master@{#392645}
==========

[commit-bot: I haz the power, 2016-05-10 18:05:27]

Patchset 11 (id:??) landed as
https://crrev.com/d8ce1c2c02a0a77a8853ec1d0ced673fd77388a8
Cr-Commit-Position: refs/heads/master@{#392645}