Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1944603002: Delete WebGraphicsContext3DCommandBufferImpl. (Closed)

Created:
4 years, 7 months ago by danakj
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, dcheng, Ken Russell (switch to Gerrit), piman, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@construct
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete WebGraphicsContext3DCommandBufferImpl. Move the last of the code there into ContextProviderCommandBuffer. R=piman@chromium.org, sievers@chromium.org BUG=584497 Committed: https://crrev.com/870925d4469447c6681617f6feadc820a5a4aaf9 Cr-Commit-Position: refs/heads/master@{#391337}

Patch Set 1 #

Patch Set 2 : killitwithfire: DEPS #

Patch Set 3 : killitwithfire: rebase #

Patch Set 4 : killitwithfire: const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -290 lines) Patch
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/common/gpu/client/DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 2 3 9 chunks +99 lines, -32 lines 0 comments Download
D content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +0 lines, -102 lines 0 comments Download
D content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1937313003 Patch 40001

Messages

Total messages: 23 (10 generated)
danakj
Plus more IWYU fixes.
4 years, 7 months ago (2016-05-03 02:35:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603002/1
4 years, 7 months ago (2016-05-03 02:36:03 UTC) #3
danakj
Dropped DEPS in content/common/ and content/common/gpu/client/ as well.
4 years, 7 months ago (2016-05-03 02:39:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603002/40001
4 years, 7 months ago (2016-05-03 02:39:49 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/28588) ios_rel_device_ninja on ...
4 years, 7 months ago (2016-05-03 02:41:21 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603002/60001
4 years, 7 months ago (2016-05-03 02:43:24 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603002/80001
4 years, 7 months ago (2016-05-03 02:45:44 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/197540)
4 years, 7 months ago (2016-05-03 02:47:42 UTC) #15
piman
______ < LGTM > ------ \ ., \ . .TR d' \ k,l .R.b .t ...
4 years, 7 months ago (2016-05-03 02:59:12 UTC) #16
Ken Russell (switch to Gerrit)
Awesome!
4 years, 7 months ago (2016-05-03 18:39:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944603002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944603002/80001
4 years, 7 months ago (2016-05-03 18:53:09 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 7 months ago (2016-05-03 20:07:49 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 20:09:32 UTC) #23
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/870925d4469447c6681617f6feadc820a5a4aaf9
Cr-Commit-Position: refs/heads/master@{#391337}

Powered by Google App Engine
This is Rietveld 408576698