Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=610160
Committed: https://crrev.com/b54445320204cffd07ee9d1663f40541bac34790
Cr-Commit-Position: refs/heads/master@{#392561}

[rjwright, 2016-05-03 02:59:50]

rjwright@chromium.org changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2016-05-03 07:37:11]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[meade_UTC10, 2016-05-03 07:37:11]

lgtm

[Timothy Loh, 2016-05-03 08:07:41]

If there are going to be several more renames then please file a bug to track
them all. Also it'd be nice to have a spec link or spec diff link in the patch
description.

[rjwright, 2016-05-09 00:50:03]

Description was changed from

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

BUG=
==========

to

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=
==========

[rjwright, 2016-05-09 00:58:03]

On 2016/05/03 08:07:41, Timothy Loh wrote:
> If there are going to be several more renames then please file a bug to track
> them all. Also it'd be nice to have a spec link or spec diff link in the patch
> description.

I made a summary bug bugs.chromium.org/p/chromium/issues/detail?id=610159. Do
you want me to make sub-bugs for all the CLs I plan to make?

[rjwright, 2016-05-09 01:03:30]

Description was changed from

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=
==========

to

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=610160
==========

[Timothy Loh, 2016-05-09 09:08:25]

On 2016/05/09 00:58:03, rjwright wrote:
> On 2016/05/03 08:07:41, Timothy Loh wrote:
> > If there are going to be several more renames then please file a bug to
track
> > them all. Also it'd be nice to have a spec link or spec diff link in the
patch
> > description.
> 
> I made a summary bug bugs.chromium.org/p/chromium/issues/detail?id=610159. Do
> you want me to make sub-bugs for all the CLs I plan to make?

I don't think making individual bugs for each patch is useful (hence why I wrote
"_a_ bug to track them all"), and there's no rule that requires a separate bug
for each change. The code change is fine (lgtm), but not everyone will have as
much context as you do. Patch descriptions and bugs are to help other people
understand what you're doing. The point of a bug here is to provide context and
link together related patches. It'd also be nice if it was written somewhere
that these patches are because the names in the spec have changed (and maybe a
reminder that this is behind a flag and not shipping yet).

[rjwright, 2016-05-10 00:44:28]

On 2016/05/09 09:08:25, Timothy Loh wrote:
> On 2016/05/09 00:58:03, rjwright wrote:
> > On 2016/05/03 08:07:41, Timothy Loh wrote:
> > > If there are going to be several more renames then please file a bug to
> track
> > > them all. Also it'd be nice to have a spec link or spec diff link in the
> patch
> > > description.
> > 
> > I made a summary bug bugs.chromium.org/p/chromium/issues/detail?id=610159.
Do
> > you want me to make sub-bugs for all the CLs I plan to make?
> 
> I don't think making individual bugs for each patch is useful (hence why I
wrote
> "_a_ bug to track them all"), and there's no rule that requires a separate bug
> for each change. The code change is fine (lgtm), but not everyone will have as
> much context as you do. Patch descriptions and bugs are to help other people
> understand what you're doing. The point of a bug here is to provide context
and
> link together related patches. It'd also be nice if it was written somewhere
> that these patches are because the names in the spec have changed (and maybe a
> reminder that this is behind a flag and not shipping yet).

Yeah, fair enough. Sorry for the lack of description. I didn't bother much
because I knew the reviewers were familiar with the objective, but I understand
why it's good to do them anyway.

I ended up making a bug for each section for my own convenience. I'll update the
master bug with a comment about spec changes.

[rjwright, 2016-05-10 00:44:57]

The CQ bit was checked by rjwright@chromium.org

[commit-bot: I haz the power, 2016-05-10 00:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943733002/1

[commit-bot: I haz the power, 2016-05-10 01:58:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 01:58:41]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rjwright, 2016-05-10 05:47:13]

The CQ bit was checked by rjwright@chromium.org

[rjwright, 2016-05-10 05:47:13]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1943733002/#ps20001
(title: "Fix webexposed test")

[commit-bot: I haz the power, 2016-05-10 05:47:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943733002/20001

[commit-bot: I haz the power, 2016-05-10 07:29:30]

Description was changed from

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=610160
==========

to

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=610160
==========

[commit-bot: I haz the power, 2016-05-10 07:29:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 07:31:39]

Description was changed from

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=610160
==========

to

==========
Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

BUG=610160

Committed: https://crrev.com/b54445320204cffd07ee9d1663f40541bac34790
Cr-Commit-Position: refs/heads/master@{#392561}
==========

[commit-bot: I haz the power, 2016-05-10 07:31:40]

Patchset 2 (id:??) landed as
https://crrev.com/b54445320204cffd07ee9d1663f40541bac34790
Cr-Commit-Position: refs/heads/master@{#392561}