Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: third_party/WebKit/Source/core/css/cssom/LengthValue.cpp

Issue 1943733002: Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix webexposed test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/LengthValue.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/LengthValue.cpp b/third_party/WebKit/Source/core/css/cssom/LengthValue.cpp
index 637f5076a9d7baa48b920d3c8836f105a2ee2146..d6643239fbeb54084ed0e5a691d74e99092519ce 100644
--- a/third_party/WebKit/Source/core/css/cssom/LengthValue.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/LengthValue.cpp
@@ -20,18 +20,18 @@ CSSPrimitiveValue::UnitType LengthValue::unitFromName(const String& name)
return CSSPrimitiveValue::fromName(name);
}
-LengthValue* LengthValue::parse(const String& cssString, ExceptionState& exceptionState)
+LengthValue* LengthValue::from(const String& cssString, ExceptionState& exceptionState)
{
// TODO: Implement
return nullptr;
}
-LengthValue* LengthValue::fromValue(double value, const String& type, ExceptionState&)
+LengthValue* LengthValue::from(double value, const String& type, ExceptionState&)
{
return SimpleLength::create(value, unitFromName(type));
}
-LengthValue* LengthValue::fromDictionary(const CalcDictionary& dictionary, ExceptionState& exceptionState)
+LengthValue* LengthValue::from(const CalcDictionary& dictionary, ExceptionState& exceptionState)
{
return StyleCalcLength::create(dictionary, exceptionState);
}
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/LengthValue.h ('k') | third_party/WebKit/Source/core/css/cssom/LengthValue.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698