third_party/WebKit/Source/core/css/cssom/LengthValue.h - Issue 1943733002: Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/LengthValue.h

Issue 1943733002: Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix webexposed test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/Source/core/css/cssom/LengthValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/LengthValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/LengthValue.h b/third_party/WebKit/Source/core/css/cssom/LengthValue.h

index 9232d6ac1d7e5445f955df5a4d829391b35fbe0d..7e17460f33bf34a013710470f698072ab80d74be 100644

--- a/third_party/WebKit/Source/core/css/cssom/LengthValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/LengthValue.h

@@ -25,9 +25,9 @@ public:

virtual bool containsPercent() const = 0;

- static LengthValue* parse(const String& cssString, ExceptionState&);

- static LengthValue* fromValue(double value, const String& typeStr, ExceptionState&);

- static LengthValue* fromDictionary(const CalcDictionary&, ExceptionState&);

+ static LengthValue* from(const String& cssString, ExceptionState&);

+ static LengthValue* from(double value, const String& typeStr, ExceptionState&);

+ static LengthValue* from(const CalcDictionary&, ExceptionState&);

protected:

LengthValue() {}