Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/LengthValue.cpp

Issue 1943733002: Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix webexposed test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/cssom/LengthValue.h" 5 #include "core/css/cssom/LengthValue.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "core/css/cssom/CalcDictionary.h" 8 #include "core/css/cssom/CalcDictionary.h"
9 #include "core/css/cssom/SimpleLength.h" 9 #include "core/css/cssom/SimpleLength.h"
10 #include "core/css/cssom/StyleCalcLength.h" 10 #include "core/css/cssom/StyleCalcLength.h"
11 #include "wtf/HashMap.h" 11 #include "wtf/HashMap.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 CSSPrimitiveValue::UnitType LengthValue::unitFromName(const String& name) 15 CSSPrimitiveValue::UnitType LengthValue::unitFromName(const String& name)
16 { 16 {
17 if (equalIgnoringASCIICase(name, "percent") || name == "%") { 17 if (equalIgnoringASCIICase(name, "percent") || name == "%") {
18 return CSSPrimitiveValue::UnitType::Percentage; 18 return CSSPrimitiveValue::UnitType::Percentage;
19 } 19 }
20 return CSSPrimitiveValue::fromName(name); 20 return CSSPrimitiveValue::fromName(name);
21 } 21 }
22 22
23 LengthValue* LengthValue::parse(const String& cssString, ExceptionState& excepti onState) 23 LengthValue* LengthValue::from(const String& cssString, ExceptionState& exceptio nState)
24 { 24 {
25 // TODO: Implement 25 // TODO: Implement
26 return nullptr; 26 return nullptr;
27 } 27 }
28 28
29 LengthValue* LengthValue::fromValue(double value, const String& type, ExceptionS tate&) 29 LengthValue* LengthValue::from(double value, const String& type, ExceptionState& )
30 { 30 {
31 return SimpleLength::create(value, unitFromName(type)); 31 return SimpleLength::create(value, unitFromName(type));
32 } 32 }
33 33
34 LengthValue* LengthValue::fromDictionary(const CalcDictionary& dictionary, Excep tionState& exceptionState) 34 LengthValue* LengthValue::from(const CalcDictionary& dictionary, ExceptionState& exceptionState)
35 { 35 {
36 return StyleCalcLength::create(dictionary, exceptionState); 36 return StyleCalcLength::create(dictionary, exceptionState);
37 } 37 }
38 38
39 LengthValue* LengthValue::add(const LengthValue* other, ExceptionState& exceptio nState) 39 LengthValue* LengthValue::add(const LengthValue* other, ExceptionState& exceptio nState)
40 { 40 {
41 if (type() == other->type() || type() == CalcLengthType) 41 if (type() == other->type() || type() == CalcLengthType)
42 return addInternal(other, exceptionState); 42 return addInternal(other, exceptionState);
43 43
44 StyleCalcLength* result = StyleCalcLength::create(this, exceptionState); 44 StyleCalcLength* result = StyleCalcLength::create(this, exceptionState);
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 return nullptr; 82 return nullptr;
83 } 83 }
84 84
85 LengthValue* LengthValue::divideInternal(double, ExceptionState&) 85 LengthValue* LengthValue::divideInternal(double, ExceptionState&)
86 { 86 {
87 ASSERT_NOT_REACHED(); 87 ASSERT_NOT_REACHED();
88 return nullptr; 88 return nullptr;
89 } 89 }
90 90
91 } // namespace blink 91 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/LengthValue.h ('k') | third_party/WebKit/Source/core/css/cssom/LengthValue.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698