third_party/WebKit/LayoutTests/typedcssom/lengthValue.html - Issue 1943733002: Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/lengthValue.html

Issue 1943733002: Typed CSSOM: Rename LengthValue parse, fromValue and fromDictionary to 'from'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix webexposed test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/typedcssom/lengthValue.html

diff --git a/third_party/WebKit/LayoutTests/typedcssom/lengthValue.html b/third_party/WebKit/LayoutTests/typedcssom/lengthValue.html

index d63254c98507d2fe8c5b3681058bc1f3e26075d7..760415b89870d9532e5e590eff1855527e5b77c8 100644

--- a/third_party/WebKit/LayoutTests/typedcssom/lengthValue.html

+++ b/third_party/WebKit/LayoutTests/typedcssom/lengthValue.html

@@ -4,18 +4,18 @@

test(function() {

- var result = LengthValue.fromValue(5, 'px');

+ var result = LengthValue.from(5, 'px');

assert_true(result instanceof SimpleLength);

assert_equals(result.value, 5);

assert_equals(result.type, 'px');

-}, "Test that LengthValue's static fromValue method produces a SimpleLength.");

+}, "Test that LengthValue's static from(double value, LengthType type) method produces a SimpleLength.");

test(function() {

- var result = LengthValue.fromDictionary({px: 1, percent: 2.5});

+ var result = LengthValue.from({px: 1, percent: 2.5});

assert_true(result instanceof CalcLength);

assert_equals(result.px, 1);

assert_equals(result.percent, 2.5);

-}, "Test that LengthValue's static fromDictionary method produces a CalcLength.");

+}, "Test that LengthValue's static from(CalcDictionary dictionary) method produces a CalcLength.");

</script>

<body>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »