GN: forward_variables_from shouldn't clobber vars.

GN: forward_variables_from shouldn't clobber vars.

The documentation for forward_variables_from specifies that it will give an error if the variable already exists in the target scope. But this was not implemented. Instead, the value would be silently overwritten.

This change implements the error, and fixes the times this happens in the Linux and Android builds.

Committed: https://crrev.com/0785c950dce7221b10c21e911795e181076b90db
Cr-Commit-Position: refs/heads/master@{#391136}

[brettw, 2016-05-02 21:53:26]

brettw@chromium.org changed reviewers:
+ agrieve@chromium.org

[brettw, 2016-05-02 22:20:29]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 22:21:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943583002/40001

[agrieve, 2016-05-03 00:14:09]

lgtm with one question

https://codereview.chromium.org/1943583002/diff/40001/build/toolchain/gcc_too...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/1943583002/diff/40001/build/toolchain/gcc_too...
build/toolchain/gcc_toolchain.gni:421: is_clang = invoker.is_clang
why did these need to be broken out?

[commit-bot: I haz the power, 2016-05-03 00:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 00:43:55]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-05-03 01:02:44]

https://codereview.chromium.org/1943583002/diff/40001/build/toolchain/gcc_too...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/1943583002/diff/40001/build/toolchain/gcc_too...
build/toolchain/gcc_toolchain.gni:421: is_clang = invoker.is_clang
On 2016/05/03 00:14:09, agrieve wrote:
> why did these need to be broken out?

These are all global variables and in this case we specifically want to clobber
if they invoker ones are defined.

[brettw, 2016-05-03 01:02:48]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-05-03 01:03:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943583002/40001

[commit-bot: I haz the power, 2016-05-03 01:06:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 01:09:24]

Description was changed from

==========
GN: forward_variables_from shouldn't clobber vars.

The documentation for forward_variables_from specifies that it will give an
error if the variable already exists in the target scope. But this was not
implemented. Instead, the value would be silently overwritten.

This change implements the error, and fixes the times this happens in the Linux
and Android builds.
==========

to

==========
GN: forward_variables_from shouldn't clobber vars.

The documentation for forward_variables_from specifies that it will give an
error if the variable already exists in the target scope. But this was not
implemented. Instead, the value would be silently overwritten.

This change implements the error, and fixes the times this happens in the Linux
and Android builds.

Committed: https://crrev.com/0785c950dce7221b10c21e911795e181076b90db
Cr-Commit-Position: refs/heads/master@{#391136}
==========

[commit-bot: I haz the power, 2016-05-03 01:09:25]

Patchset 3 (id:??) landed as
https://crrev.com/0785c950dce7221b10c21e911795e181076b90db
Cr-Commit-Position: refs/heads/master@{#391136}

[Dirk Pranke, 2016-05-03 02:42:08]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-05-03 02:42:08]

lgtm also