testing/test.gni - Issue 1943583002: GN: forward_variables_from shouldn't clobber vars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test.gni

Issue 1943583002: GN: forward_variables_from shouldn't clobber vars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/test.gni

diff --git a/testing/test.gni b/testing/test.gni

index 650940e69744d9121373922ed4241e316b3fc27a..c01306c644880a3b574cda10aec1445640e51451 100644

--- a/testing/test.gni

+++ b/testing/test.gni

@@ -97,7 +97,6 @@ template("test") {

_device_isolate_path = "$root_out_dir/gen.runtime/$_target_dir_name/$target_name.device.isolate"

_gen_isolate_target_name = "${target_name}__isolate"

_gen_isolate(_gen_isolate_target_name) {

- data_deps = []

forward_variables_from(invoker,

[

"data",