Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: build/toolchain/nacl_toolchain.gni

Issue 1943583002: GN: forward_variables_from shouldn't clobber vars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2014 The Native Client Authors. All rights reserved. 1 # Copyright (c) 2014 The Native Client Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/nacl/config.gni") 5 import("//build/config/nacl/config.gni")
6 import("//build/toolchain/gcc_toolchain.gni") 6 import("//build/toolchain/gcc_toolchain.gni")
7 7
8 # This template defines a NaCl toolchain. 8 # This template defines a NaCl toolchain.
9 # 9 #
10 # It requires the following variables specifying the executables to run: 10 # It requires the following variables specifying the executables to run:
(...skipping 20 matching lines...) Expand all
31 } else { 31 } else {
32 executable_extension = ".nexe" 32 executable_extension = ".nexe"
33 } 33 }
34 34
35 forward_variables_from(invoker, 35 forward_variables_from(invoker,
36 [ 36 [
37 "ar", 37 "ar",
38 "cc", 38 "cc",
39 "cxx", 39 "cxx",
40 "deps", 40 "deps",
41 "is_clang",
42 "is_nacl_glibc",
43 "ld", 41 "ld",
44 "link_outputs", 42 "link_outputs",
45 "nm", 43 "nm",
46 "readelf", 44 "readelf",
47 "strip", 45 "strip",
48 "symbol_level", 46 "symbol_level",
49 "toolchain_cpu", 47 "toolchain_cpu",
50 ]) 48 ])
51 49
50 if (defined(invoker.is_clang)) {
51 is_clang = invoker.is_clang
52 }
53 if (defined(invoker.is_nacl_glibc)) {
54 is_nacl_glibc = invoker.is_nacl_glibc
55 }
56
52 # We do not support component builds or sanitizers with the NaCl toolchains. 57 # We do not support component builds or sanitizers with the NaCl toolchains.
53 is_component_build = false 58 is_component_build = false
54 clear_sanitizers = true 59 clear_sanitizers = true
55 60
56 # We do not support tcmalloc in the NaCl toolchains. 61 # We do not support tcmalloc in the NaCl toolchains.
57 use_allocator = "none" 62 use_allocator = "none"
58 63
59 rebuild_define = "NACL_TC_REV=" + invoker.toolchain_revision 64 rebuild_define = "NACL_TC_REV=" + invoker.toolchain_revision
60 } 65 }
61 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698