Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: components/cronet/android/BUILD.gn

Issue 1943583002: GN: forward_variables_from shouldn't clobber vars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index f59c54ee28fab01085f077f72eb63e2b9305976c..ee5bc3fc17f403c3bf2f0662a28e5cbe4f0cfe18 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -267,7 +267,7 @@ android_library("cronet_api") {
":network_quality_observations_java",
]
- run_findbugs = true
+ run_findbugs_override = true
}
android_library("cronet_java") {
@@ -304,7 +304,7 @@ android_library("cronet_java") {
":net_request_priority_java",
]
- run_findbugs = true
+ run_findbugs_override = true
}
android_resources("cronet_sample_apk_resources") {
@@ -325,7 +325,7 @@ android_library("cronet_sample_apk_java") {
"//base:base_java",
]
- run_findbugs = true
+ run_findbugs_override = true
}
android_apk("cronet_sample_apk") {
@@ -341,7 +341,7 @@ android_apk("cronet_sample_apk") {
"//third_party/jsr-305:jsr_305_javalib",
]
- run_findbugs = true
+ run_findbugs_override = true
if (!is_debug) {
proguard_enabled = true
proguard_configs = [
@@ -380,7 +380,7 @@ instrumentation_test_apk("cronet_sample_test_apk") {
]
additional_apks = [ "//net/android:net_test_support_apk" ]
- run_findbugs = true
+ run_findbugs_override = true
proguard_enabled = !is_debug
}
@@ -485,7 +485,7 @@ android_library("cronet_test_apk_java") {
"//third_party/netty4:netty_all",
]
- run_findbugs = true
+ run_findbugs_override = true
}
android_assets("cronet_test_apk_assets") {
@@ -544,7 +544,7 @@ android_apk("cronet_test_apk") {
"//third_party/netty-tcnative:netty-tcnative_all",
]
- run_findbugs = true
+ run_findbugs_override = true
}
android_library("cronet_javatests") {
@@ -597,7 +597,7 @@ android_library("cronet_javatests") {
"//net/android:net_java_test_support",
]
- run_findbugs = true
+ run_findbugs_override = true
}
instrumentation_test_apk("cronet_test_instrumentation_apk") {
@@ -627,7 +627,7 @@ instrumentation_test_apk("cronet_test_instrumentation_apk") {
# TODO(jbudorick): Remove this once GN uses the generated .isolate files.
isolate_file = "cronet_test_instrumentation_apk.isolate"
- run_findbugs = true
+ run_findbugs_override = true
}
android_library("cronet_perf_test_apk_java") {
@@ -643,7 +643,7 @@ android_library("cronet_perf_test_apk_java") {
"//base:base_java",
]
- run_findbugs = true
+ run_findbugs_override = true
}
android_apk("cronet_perf_test_apk") {
@@ -659,7 +659,7 @@ android_apk("cronet_perf_test_apk") {
"//base:base_java",
]
- run_findbugs = true
+ run_findbugs_override = true
proguard_enabled = true
proguard_configs = [
"proguard.cfg",

Powered by Google App Engine
This is Rietveld 408576698