third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp - Issue 1936593002: [DevTools] Remove state from v8 agent wrappers, remove unnecessary classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

Issue 1936593002: [DevTools] Remove state from v8 agent wrappers, remove unnecessary classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-everything-from-agents

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

index 400166cb695fe529e8a50864e29e6d6b69792379..f23095dfb36cef28de174c6ab61993690b0a3bb8 100644

--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

@@ -32,12 +32,12 @@

#include "core/InstrumentingAgents.h"

#include "core/inspector/InspectorConsoleAgent.h"

+#include "core/inspector/InspectorDebuggerAgent.h"

#include "core/inspector/InspectorHeapProfilerAgent.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/InspectorProfilerAgent.h"

+#include "core/inspector/InspectorRuntimeAgent.h"

#include "core/inspector/WorkerConsoleAgent.h"

-#include "core/inspector/WorkerDebuggerAgent.h"

-#include "core/inspector/WorkerRuntimeAgent.h"

#include "core/inspector/WorkerThreadDebugger.h"

#include "core/workers/WorkerGlobalScope.h"

#include "core/workers/WorkerReportingProxy.h"

@@ -77,10 +77,10 @@ void WorkerInspectorController::connectFrontend()

m_session = new InspectorSession(this, nullptr, m_instrumentingAgents.get(), 0, true /* autoFlush */);

m_v8Session = m_debugger->debugger()->connect(m_debugger->contextGroupId());

- m_session->append(WorkerRuntimeAgent::create(m_v8Session->runtimeAgent(), m_workerGlobalScope));

- m_session->append(WorkerDebuggerAgent::create(m_v8Session->debuggerAgent(), m_workerGlobalScope));

+ m_session->append(new InspectorRuntimeAgent(m_v8Session->runtimeAgent()));

+ m_session->append(new InspectorDebuggerAgent(m_v8Session->debuggerAgent()));

m_session->append(new InspectorProfilerAgent(m_v8Session->profilerAgent()));

- m_session->append(InspectorHeapProfilerAgent::create(m_v8Session->heapProfilerAgent()));

+ m_session->append(new InspectorHeapProfilerAgent(m_v8Session->heapProfilerAgent()));

m_session->append(new WorkerConsoleAgent(m_v8Session.get(), m_workerGlobalScope));

m_session->attach(m_v8Session.get(), nullptr);