third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h - Issue 1936593002: [DevTools] Remove state from v8 agent wrappers, remove unnecessary classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

Issue 1936593002: [DevTools] Remove state from v8 agent wrappers, remove unnecessary classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-everything-from-agents

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

index 7914c35ebb5faf75e8efc5555a7daef8161f8107..052c99084c2929ed3cbccb5d13e47d9e94107181 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

@@ -45,7 +45,7 @@ class V8HeapProfilerAgent;

class CORE_EXPORT InspectorHeapProfilerAgent final : public InspectorBaseAgent<InspectorHeapProfilerAgent, protocol::Frontend::HeapProfiler>, public protocol::Backend::HeapProfiler {

WTF_MAKE_NONCOPYABLE(InspectorHeapProfilerAgent);

public:

- static InspectorHeapProfilerAgent* create(V8HeapProfilerAgent*);

+ explicit InspectorHeapProfilerAgent(V8HeapProfilerAgent*);

~InspectorHeapProfilerAgent() override;

// InspectorBaseAgent overrides.

@@ -66,8 +66,6 @@ public:

void stopSampling(ErrorString*, OwnPtr<protocol::HeapProfiler::SamplingHeapProfile>*) override;

private:

- explicit InspectorHeapProfilerAgent(V8HeapProfilerAgent*);

V8HeapProfilerAgent* m_v8HeapProfilerAgent;

};