Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 1936593002: [DevTools] Remove state from v8 agent wrappers, remove unnecessary classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-everything-from-agents
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp
index 669b7d39632807a9219bdf18f94e88a455408477..87056b450d48ea3da3328eadf496a73ac755668a 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp
@@ -37,10 +37,6 @@ namespace blink {
using protocol::Maybe;
-namespace DebuggerAgentState {
-static const char debuggerEnabled[] = "debuggerEnabled";
-}
-
InspectorDebuggerAgent::InspectorDebuggerAgent(V8DebuggerAgent* agent)
: InspectorBaseAgent<InspectorDebuggerAgent, protocol::Frontend::Debugger>("Debugger")
, m_v8DebuggerAgent(agent)
@@ -60,12 +56,10 @@ DEFINE_TRACE(InspectorDebuggerAgent)
void InspectorDebuggerAgent::enable(ErrorString* errorString)
{
m_v8DebuggerAgent->enable(errorString);
- m_state->setBoolean(DebuggerAgentState::debuggerEnabled, true);
}
void InspectorDebuggerAgent::disable(ErrorString* errorString)
{
- m_state->setBoolean(DebuggerAgentState::debuggerEnabled, false);
m_v8DebuggerAgent->disable(errorString);
}
@@ -271,11 +265,7 @@ void InspectorDebuggerAgent::dispose()
void InspectorDebuggerAgent::restore()
{
- if (!m_state->booleanProperty(DebuggerAgentState::debuggerEnabled, false))
- return;
m_v8DebuggerAgent->restore();
- ErrorString errorString;
- enable(&errorString);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698