[Findit] Extract failed output nodes from stdio log of compile step.

[Findit] Extract failed output nodes from stdio log of compile step.

This is a temporary solution to start experiment and collect metrics as early as we could.

BUG=596970
TBR=chanli, lijeffrey

Committed: https://chromium.googlesource.com/infra/infra/+/dd994dba70805597d2ce4af71fea0c7d690eb3bf

[stgao, 2016-04-30 01:06:49]

Description was changed from

==========
[Findit] Extract failed output nodes from stdio log of compile step.

BUG=596970
==========

to

==========
[Findit] Extract failed output nodes from stdio log of compile step.

This is a temporary solution to start experiment and collect metrics as early as
we could.

BUG=596970
==========

[stgao, 2016-04-30 01:07:08]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[stgao, 2016-04-30 01:07:08]

ptal

[chanli, 2016-04-30 02:24:58]

https://codereview.chromium.org/1933013003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/extractors.py (right):

https://codereview.chromium.org/1933013003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/extractors.py:247: while line:
Is it possible that the line is like:
FAILED: a.o "something in quotes" b.o "some other thing in quotes"?

[lijeffrey, 2016-04-30 03:44:25]

https://codereview.chromium.org/1933013003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/extractors.py (right):

https://codereview.chromium.org/1933013003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/extractors.py:248: quote_index = line.find('"')
nit: it seems since this is a temporary solution, maybe extract this into a
separate function that takes line and returns a set that will be
failed_output_nodes?

i.e. 

def _GetOutputNodesFromLine(line):
  failed_output_nodes = set()
  while line:
    quote_index = line.find('"')
    ...
  return failed_output_nodes

then later

line = line[len(self.FAILURE_START_LINE_PREFIX):]
failed_ouptut_nodes = _GetOutputNodesFromLine(line)
is_build_command_line = True
...


This way the function can be more easily tested and removed when this temporary
solution is no longer needed

[stgao, 2016-05-01 05:12:28]

https://codereview.chromium.org/1933013003/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/extractors.py (right):

https://codereview.chromium.org/1933013003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/extractors.py:247: while line:
On 2016/04/30 02:24:58, chanli wrote:
> Is it possible that the line is like:
> FAILED: a.o "something in quotes" b.o "some other thing in quotes"?

In theory, this is possible.
But in practice, when with quote, it would be more like:
FAILED: "some target with space".

And this is handled by the code below.

https://codereview.chromium.org/1933013003/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/extractors.py:248: quote_index = line.find('"')
On 2016/04/30 03:44:25, lijeffrey wrote:
> nit: it seems since this is a temporary solution, maybe extract this into a
> separate function that takes line and returns a set that will be
> failed_output_nodes?
> 
> i.e. 
> 
> def _GetOutputNodesFromLine(line):
>   failed_output_nodes = set()
>   while line:
>     quote_index = line.find('"')
>     ...
>   return failed_output_nodes
> 
> then later
> 
> line = line[len(self.FAILURE_START_LINE_PREFIX):]
> failed_ouptut_nodes = _GetOutputNodesFromLine(line)
> is_build_command_line = True
> ...
> 
> 
> This way the function can be more easily tested and removed when this
temporary
> solution is no longer needed

This is a good idea. 
Done, but with additional change.

[stgao, 2016-05-01 05:12:46]

Description was changed from

==========
[Findit] Extract failed output nodes from stdio log of compile step.

This is a temporary solution to start experiment and collect metrics as early as
we could.

BUG=596970
==========

to

==========
[Findit] Extract failed output nodes from stdio log of compile step.

This is a temporary solution to start experiment and collect metrics as early as
we could.

BUG=596970
TBR=chanli, lijeffrey
==========

[stgao, 2016-05-01 05:13:05]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2016-05-01 05:13:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933013003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933013003/20001

[commit-bot: I haz the power, 2016-05-01 05:17:50]

Description was changed from

==========
[Findit] Extract failed output nodes from stdio log of compile step.

This is a temporary solution to start experiment and collect metrics as early as
we could.

BUG=596970
TBR=chanli, lijeffrey
==========

to

==========
[Findit] Extract failed output nodes from stdio log of compile step.

This is a temporary solution to start experiment and collect metrics as early as
we could.

BUG=596970
TBR=chanli, lijeffrey

Committed:
https://chromium.googlesource.com/infra/infra/+/dd994dba70805597d2ce4af71fea0...
==========

[commit-bot: I haz the power, 2016-05-01 05:17:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/dd994dba70805597d2ce4af71fea0...

[aureliojuarezcortez, 2016-05-01 06:53:37]

On 2016/05/01 05:17:51, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/infra/infra/+/dd994dba70805597d2ce4af71fea0...
(*AurelioJuarezCortez.)

[aureliojuarezcortez, 2016-05-01 06:54:26]

On 2016/05/01 05:13:16, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1933013003/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1933013003/20001

(*AurelioJuarezCortez.)

[aureliojuarezcortez, 2017-05-08 20:26:00]

On 2016/05/01 06:54:26, aureliojuarezcortez wrote:>On 2016/05/01 05:13:16,
commit-bot: I haz the power wrote:CQ is trying da patch. Follow status at
>>  https://chromium-cq-status.appspot.com/patch-status/1933013003/20001
>>Viewtimelineat<aureliojuarezcortez@gmail.com>wow.AurelioCortezIGoogleChrome...
>>https://chromium-cq-status.appspot.com/patch-timeline/1933013003/20001
>> (*AurelioJuarezCortez.)

[aureliojuarezcortez, 2017-05-08 20:28:29]

On 2016/05/01 06:54:26, aureliojuarezcortez wrote:
> On 2016/05/01 05:13:16, commit-bot: I haz the power wrote:
>> CQ is trying da patch. Follow status at
>>https://chromium-cq-status.appspot.com/patch-status/1933013003/20001
>>aureliojuarezcortez@gmail.com>wow.AurelioCortezIGoogleChrome.ComPrivacy/
>> https://chromium-cq-status.appspot.com/patch-timeline/1933013003/20001
>>(*AurelioJuarezCortez.)

[aureliojuarezcortez, 2017-05-26 10:41:24]

On 2016/04/30 01:06:49, stgao wrote:
> Description was changed from
> 
> ==========
> [Findit] Extract failed output nodes from stdio log of compile step.
> 
> BUG=596970AurelioJuarezCortez.
> ==========
> 
> to
> 
> ==========
> [Findit] Extract failed output nodes from stdio log of compile step.
> 
> This is a temporary solution to start experiment and collect metrics as early
as
> we could.
> 
> BUG=596970AurelioJuarezCortez.
> ==========
AurelioJuarezCortez.googlesource.com19330130031933013003_20001_30001.

[aureliojuarezcortez, 2017-05-26 10:41:50]

On 2017/05/26 10:41:24, aureliojuarezcortez wrote:
> On 2016/04/30 01:06:49, stgao wrote:
> > Description was changed from
> > 
> > ==========
> > [Findit] Extract failed output nodes from stdio log of compile step.
> > 
> > BUG=596970AurelioJuarezCortez.
> > ==========
> > 
> > to
> > 
> > ==========
> > [Findit] Extract failed output nodes from stdio log of compile step.
> > 
> > This is a temporary solution to start experiment and collect metrics as
early
> as
> > we could.
> > 
> > BUG=596970AurelioJuarezCortez.
> > ==========
> AurelioJuarezCortez.googlesource.com19330130031933013003_20001_30001.

[aureliojuarezcortez, 2017-05-26 10:42:15]

On 2017/05/26 10:41:50, aureliojuarezcortez wrote:
> On 2017/05/26 10:41:24, aureliojuarezcortez wrote:
> > On 2016/04/30 01:06:49, stgao wrote:
> > > Description was changed from
> > > 
> > > ==========
> > > [Findit] Extract failed output nodes from stdio log of compile step.
> > > 
> > > BUG=596970AurelioJuarezCortez.
> > > ==========
> > > 
> > > to
> > > 
> > > ==========
> > > [Findit] Extract failed output nodes from stdio log of compile step.
> > > 
> > > This is a temporary solution to start experiment and collect metrics as
> early
> > as
> > > we could.
> > > 
> > > BUG=596970AurelioJuarezCortez.
> > > ==========
> > AurelioJuarezCortez.googlesource.com19330130031933013003_20001_30001.

[aureliojuarezcortez, 2017-05-26 10:42:37]

On 2017/05/26 10:42:15, aureliojuarezcortez wrote:
> On 2017/05/26 10:41:50, aureliojuarezcortez wrote:
> > On 2017/05/26 10:41:24, aureliojuarezcortez wrote:
> > > On 2016/04/30 01:06:49, stgao wrote:
> > > > Description was changed from
> > > > 
> > > > ==========
> > > > [Findit] Extract failed output nodes from stdio log of compile step.
> > > > 
> > > > BUG=596970AurelioJuarezCortez.
> > > > ==========
> > > > 
> > > > to
> > > > 
> > > > ==========
> > > > [Findit] Extract failed output nodes from stdio log of compile step.
> > > > 
> > > > This is a temporary solution to start experiment and collect metrics as
> > early
> > > as
> > > > we could.
> > > > 
> > > > BUG=596970AurelioJuarezCortez.
> > > > ==========
> > > AurelioJuarezCortez.googlesource.com19330130031933013003_20001_30001.