Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: appengine/findit/waterfall/test/try_job_util_test.py

Issue 1933013003: [Findit] Extract failed output nodes from stdio log of compile step. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/test/failure_signal_test.py ('k') | appengine/findit/waterfall/try_job_util.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 65f58afd018607153b19bd295ca23bac3e0c5073..706a8c82916c1adf8d83231a60258153893844ff 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -374,6 +374,21 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
self.assertTrue(_MockRootPipeline.STARTED)
self.assertIsNotNone(try_job)
+ def testUseFailedOutputNodesFromSignals(self):
+ signals = {
+ 'compile': {
+ 'failed_targets': [
+ {'target': 'a.exe'},
+ {'source': 'b.cc', 'target': 'b.o'},
+ ],
+ 'failed_output_nodes': ['a', 'b'],
+ }
+ }
+
+ self.assertEqual(
+ try_job_util._GetFailedTargetsFromSignals(signals, 'm', 'b'),
+ ['a', 'b'])
+
def testGetFailedTargetsFromSignals(self):
self.assertEqual(
try_job_util._GetFailedTargetsFromSignals({}, 'm', 'b'), [])
« no previous file with comments | « appengine/findit/waterfall/test/failure_signal_test.py ('k') | appengine/findit/waterfall/try_job_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698