[Findit] Extract failed output nodes from stdio log of compile step.

appengine/findit/waterfall/test/extractors_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import textwrap
 
 from waterfall import extractors
 from waterfall.extractor import Extractor
 from waterfall.test import wf_testcase
 
@@ skipping 268 matching lines @@
         'keywords': {}
     }
 
     self._RunTest(
         failure_log, extractors.GeneralExtractor, expected_signal_json)
 
   def testCompileStepExtractor(self):
     failure_log = textwrap.dedent("""
         [1832/2467 | 117.498] CXX obj/a/b/test.file.o
         blabla...
-        FAILED: obj/a/b/test.c.o
+        FAILED: obj/a/b/test.c.o 
         /b/build/goma/gomacc blabla ... -c ../../a/b/c.cc -o obj/a/b/test.c.o
         ../../a/b/c.cc:307:44: error: no member 'kEnableExtensionInfoDialog' ...
         1 error generated.
         x/y/not_in_signal.cc
-        FAILED: obj/a/b/test.d.o
+        FAILED: obj/a/b/test.d.o 
         /b/build/goma/gomacc blabla ... -c ../../a/b/d.cc -o obj/a/b/test.d.o
         ../../a/b/d.cc:123:44: error: no member 'kEnableExtensionInfoDialog' ...
         blabla...
         1 error generated.
-        FAILED: obj/a/b/test.e.o
+        FAILED: obj/a/b/test.e.o 
         /b/build/goma/gomacc ... ../../a/b/e.cc ... obj/a/b/test.e.o
         ../../a/b/e.cc:79:44: error: no member 'kEnableExtensionInfoDialog' ...
         blabla...
         ninja: build stopped: subcommand failed.
 
         /b/build/goma/goma_ctl.sh stat
         blabla...""")
     expected_signal_json = {
         'files': {
             'a/b/c.cc': [307],
             'a/b/d.cc': [123],
             'a/b/e.cc': [79]
         },
-        'keywords': {}
+        'keywords': {},
+        'failed_output_nodes': [
+            'obj/a/b/test.c.o',
+            'obj/a/b/test.d.o',
+            'obj/a/b/test.e.o',
+        ],
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json)
 
   def testCompileStepExtractorExtractFailedCompileTargetsLinux(self):
     failure_log = textwrap.dedent("""
         [1832/2467 | 117.498] CXX obj/a/b/test.file.o
         blabla...
         FAILED: obj/a/b/c.o
@@ skipping 29 matching lines @@
                 'source': '../../a/b/c.cc',
                 'target': 'obj/a/b/c.o',
             },
             {
                 'source': '../../a/b/x.cc',
                 'target': 'obj/a/b/x.o',
             },
             {
                 'target': 'target.exe'
             }
-        ]
+        ],
+        'failed_output_nodes': [
+            'notgoma.exe',
+            'obj/a/b/c.o',
+            'obj/a/b/x.o',
+            'target.exe',
+        ],
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json,
         'builder2', 'master2')
 
   def testCompileStepExtractorExtractFailedTargetsLinuxOutsideFailure(self):
     failure_log = textwrap.dedent("""
         [1780/30023] blabla
         FAILED: blabla
         blabla
         1 error generated.
         FAILED with 1: blabla gomacc -c a/b.cc -o c/d.o blabla
         blabla
         Error: FAILED with 1: blabla
         ninja: build stopped: subcommand failed.
         blabla.""")
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'source': 'a/b.cc',
                 'target': 'c/d.o'
             }
-        ]
+        ],
+        'failed_output_nodes': [
+            'blabla',
+        ],
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json,
         'builder2', 'master2')
 
   def testCompileStepExtractorExtractFailedLinkTargetsLinux(self):
     failure_log = textwrap.dedent("""
         [5430/5600] blabla
         FAILED: a/b.nexe
         python blabla clang++ -o a/b.nexe blabla
         blabla
         blabla.Error: FAILED with blabla
         FAILED: "target with spaces and quotes"
         blabla gomacc -o "target with spaces and quotes" blabla
         ninja: build stopped: subcommand failed.""")
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'target': 'a/b.nexe'
             },
             {
                 'target': '"target with spaces and quotes"'
             }
-        ]
+        ],
+        'failed_output_nodes': [
+            'a/b.nexe',
+            'target with spaces and quotes',
+        ],
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json,
         'builder2', 'master2')
 
   def testCompileStepExtractorExtractFailedCompileTargetsWindows(self):
     failure_log = textwrap.dedent("""
         [4576/31353] blabla
         FAILED: a\\b.c.obj
         ninja blabla /c ..\\..\\a\\b\\c.cc /Foa\\b.c.obj blabla
         blabla
         1 error generated.
         FAILED: d\\e\\f\\a.b.obj
         ninja blabla /c ..\\..\\d\\e\\f.cc /Fod\\e\\f\\a.b.obj blabla
         blabla
         ninja: build stopped: subcommand failed.""")
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'source': '..\\..\\a\\b\\c.cc',
                 'target': 'a\\b.c.obj',
             },
             {
                 'source': '..\\..\\d\\e\\f.cc',
                 'target': 'd\\e\\f\\a.b.obj'
             },
-        ]
+        ],
+        'failed_output_nodes': [
+            'a\\b.c.obj',
+            'd\\e\\f\\a.b.obj',
+        ],
     }
 
     self._RunTest(failure_log, extractors.CompileStepExtractor,
                   expected_signal_json, 'win_builder', 'win_master')
 
   def testCompileStepExtractorExtractFailedLinkTargetsWindows(self):
     failure_log = textwrap.dedent("""
         [11428/27088] blabla
         FAILED: test.exe
         blabla link.exe /OUT:test.exe @test.exe.rsp blabla
         ninja: build stopped: subcommand failed.""")
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'target': 'test.exe'
             }
-        ]
+        ],
+        'failed_output_nodes': [
+            'test.exe',
+        ],
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json,
         'builder2', 'master2')
 
   def testCompileStepNinjaErrorExtractor(self):
     """Test ninja error extraction in compile step."""
     failure_log = textwrap.dedent("""
         ninja -C /a/b/c/ all -j50
@@ skipping 70 matching lines @@
         /b/build/goma/goma_ctl.sh stat
         blabla...""" % (goma_clang_prefix, goma_clang_prefix))
     expected_signal_json = {
         'files': {},
         'keywords': {},
         'failed_targets': [
             {
                 'source': 'a.c',
                 'target': 'obj/a.o',
             },
-        ]
+        ],
+        'failed_output_nodes': [
+            'obj/a.o',
+        ],
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json)
 
   def testCompileStepStrictRegexForLinkFailures(self):
-
     goma_gcc_prefix = (
         '/b/build/slave/Linux/build/src/build/goma/client/gomacc '
         '/bla/bla/.../bin/arm-linux-androideabi-gcc')
     failure_log = textwrap.dedent("""
         [1832/2467 | 117.498] CXX obj/a/b/test.file.o
         blabla...
         FAILED: obj/a.o
         %s -Wl,-z,now ... -o exe -Wl,--start-group obj/a.o ...
         blalba...
-        FAILED: cd a/b/c; python script.py a b c blabla....
+        FAILED: action_output_name
+        cd a/b/c; python script.py a b c blabla....
         blalba...
         ninja: build stopped: subcommand failed.
 
+        /b/build/goma/goma_ctl.sh stat
+        blabla...""" % goma_gcc_prefix)
+    expected_signal_json = {
+        'files': {
+        },
+        'keywords': {},
+        'failed_targets': [
+            {
+                'target': 'exe',
+            },
+        ],
+        'failed_output_nodes': [
+            'action_output_name',
+            'obj/a.o',
+        ],
+    }
+
+    self._RunTest(
+        failure_log, extractors.CompileStepExtractor, expected_signal_json)
+
+  def testCompileStepNoMatchingQuote(self):
+    goma_gcc_prefix = (
+        '/b/build/slave/Linux/build/src/build/goma/client/gomacc '
+        '/bla/bla/.../bin/arm-linux-androideabi-gcc')
+    failure_log = textwrap.dedent("""
+        [1832/2467 | 117.498] CXX obj/a/b/test.file.o
+        blabla...
+        FAILED: a "b no matching quote
+        %s -Wl,-z,now ... -o exe -Wl,--start-group obj/a.o ...
+        blalba...
+        ninja: build stopped: subcommand failed.
+
         /b/build/goma/goma_ctl.sh stat
         blabla...""" % goma_gcc_prefix)
     expected_signal_json = {
         'files': {
         },
         'keywords': {},
         'failed_targets': [
             {
                 'target': 'exe',
             },
-        ]
+        ],
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json)
 
   def testCheckPermExtractor(self):
     failure_log = textwrap.dedent("""
         a/b/c.py
         ...
         FAILED whitespace.txt
@@ skipping 232 matching lines @@
         # step_name: result
         '1': '1',
         '2': '2',
         '32434': '0'
     }
 
     for step_name, expected_result in cases.iteritems():
       result = extractors.ExtractSignal(
           'master', 'bot', step_name, 'test', '')
       self.assertEqual(expected_result, result)