Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: appengine/findit/waterfall/try_job_util.py

Issue 1933013003: [Findit] Extract failed output nodes from stdio log of compile step. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/test/try_job_util_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 7273548b062a647cf0164c986d2f3ef8abcd2f86..f0bdeb796804c9db2b7a71ff4c2d959a3167ca1b 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -119,6 +119,9 @@ def _GetFailedTargetsFromSignals(signals, master_name, builder_name):
if not signals or 'compile' not in signals:
return compile_targets
+ if signals['compile'].get('failed_output_nodes'):
+ return signals['compile'].get('failed_output_nodes')
+
strict_regex = waterfall_config.EnableStrictRegexForCompileLinkFailures(
master_name, builder_name)
for source_target in signals['compile'].get('failed_targets', []):
« no previous file with comments | « appengine/findit/waterfall/test/try_job_util_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698