appengine/findit/waterfall/test/failure_signal_test.py - Issue 1933013003: [Findit] Extract failed output nodes from stdio log of compile step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/failure_signal_test.py

Issue 1933013003: [Findit] Extract failed output nodes from stdio log of compile step. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/waterfall/test/failure_signal_test.py

diff --git a/appengine/findit/waterfall/test/failure_signal_test.py b/appengine/findit/waterfall/test/failure_signal_test.py

index e7ce96b60224bb129411791953049b4748ef01f4..69c1407279403d1a0f8f0de8169e3b811f812d8e 100644

--- a/appengine/findit/waterfall/test/failure_signal_test.py

+++ b/appengine/findit/waterfall/test/failure_signal_test.py

@@ -47,7 +47,10 @@ class FailureSignalTest(unittest.TestCase):

'keywords': {

'k1': 3

- }

+ },

+ 'failed_output_nodes': [

+ 'obj/path/to/file.o',

+ ],

}

signal = FailureSignal.FromDict(data)

self.assertEqual(data, signal.ToDict())

« no previous file with comments | « appengine/findit/waterfall/test/extractors_test.py ('k') | appengine/findit/waterfall/test/try_job_util_test.py » ('j') | no next file with comments »