Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1924713002: [DevTools] Removed InjectedScriptHost (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-inspect-to-native
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed InjectedScriptHost - V8InjectedScriptHost become simple object, - remove InjectedScriptHost, - remove InspectorWrapper, - remove callFunction method and replace it with suppressWarningsAndCallFunction method, we don't want to expose any errors from InjectedScript, - cleanup V8InjectedScriptHost code. BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44 Cr-Commit-Position: refs/heads/master@{#390196}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -448 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 2 3 4 chunks +3 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h View 1 2 3 2 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 2 3 8 chunks +81 lines, -127 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js View 1 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
kozy
Dmitry, please take a look. https://codereview.chromium.org/1924713002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt File third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt (left): https://codereview.chromium.org/1924713002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt#oldcode1 third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt:1: CONSOLE ERROR: line 26: ...
4 years, 8 months ago (2016-04-27 04:47:01 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp (right): https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp#newcode33 third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:33: ASSERT(!info.Data()->IsExternal()); ASSERT(info.Data()->IsExternal()); https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp#newcode35 third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:35: V8DebuggerImpl* debugger = static_cast<V8DebuggerImpl*>(debuggerExternal.As<v8::External>()->Value()); ...
4 years, 7 months ago (2016-04-27 18:28:54 UTC) #4
kozy
Pavel, please take a look. I need owner lgtm for gypi.
4 years, 7 months ago (2016-04-27 18:32:04 UTC) #6
kozy
All done. https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp (right): https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp#newcode33 third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:33: ASSERT(!info.Data()->IsExternal()); On 2016/04/27 18:28:54, dgozman wrote: > ...
4 years, 7 months ago (2016-04-27 18:41:51 UTC) #7
pfeldman
lgtm
4 years, 7 months ago (2016-04-27 20:49:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924713002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924713002/60001
4 years, 7 months ago (2016-04-27 21:10:21 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-27 21:36:44 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:13:26 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44
Cr-Commit-Position: refs/heads/master@{#390196}

Powered by Google App Engine
This is Rietveld 408576698