[DevTools] Removed InjectedScriptHost

[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction method, we don't want to expose any errors from InjectedScript,
- cleanup V8InjectedScriptHost code.

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44
Cr-Commit-Position: refs/heads/master@{#390196}

[kozy, 2016-04-27 04:44:45]

Description was changed from

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction
method, we don't want to expose any errors from InjectedScript.

BUG=595206
R=dgozman@chromium.org
==========

[kozy, 2016-04-27 04:45:49]

Description was changed from

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction
method, we don't want to expose any errors from InjectedScript.

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction
method, we don't want to expose any errors from InjectedScript,
- cleanup V8InjectedScriptHost code.

BUG=595206
R=dgozman@chromium.org
==========

[kozy, 2016-04-27 04:47:01]

Dmitry, please take a look.

https://codereview.chromium.org/1924713002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt
(left):

https://codereview.chromium.org/1924713002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt:1:
CONSOLE ERROR: line 26: Uncaught SyntaxError: Unexpected identifier
It's good change. This errors points to InjectedScript and absolutely useless.

[dgozman, 2016-04-27 18:28:54]

lgtm

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:33:
ASSERT(!info.Data()->IsExternal());
ASSERT(info.Data()->IsExternal());

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:35:
V8DebuggerImpl* debugger =
static_cast<V8DebuggerImpl*>(debuggerExternal.As<v8::External>()->Value());
redundant .As<v8::External>

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:45:
v8::Local<v8::Context> context = isolate->GetCurrentContext();
Let's pass context for the case we create injected script while handling
protocol command.

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:194: if
(info.Length() < 2 || info.Length() > 3 || !info[0]->IsFunction() ||
(info.Length() > 2 && (!info[2]->IsArray() && !info[2]->IsUndefined()))) {
Let's make two early returns.

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h
(right):

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h:21:
static v8::Local<v8::Object> create(V8DebuggerImpl*);
Note that we expect that debugger outlives any JS context and thus
V8InjectedScriptHost (owned by JS) is destroyed before debugger.

[kozy, 2016-04-27 18:32:04]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-04-27 18:32:04]

Pavel, please take a look. I need owner lgtm for gypi.

[kozy, 2016-04-27 18:41:51]

All done.

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:33:
ASSERT(!info.Data()->IsExternal());
On 2016/04/27 18:28:54, dgozman wrote:
> ASSERT(info.Data()->IsExternal());

Done.

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:35:
V8DebuggerImpl* debugger =
static_cast<V8DebuggerImpl*>(debuggerExternal.As<v8::External>()->Value());
On 2016/04/27 18:28:54, dgozman wrote:
> redundant .As<v8::External>

Done.

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:45:
v8::Local<v8::Context> context = isolate->GetCurrentContext();
On 2016/04/27 18:28:54, dgozman wrote:
> Let's pass context for the case we create injected script while handling
> protocol command.

Done.

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:194: if
(info.Length() < 2 || info.Length() > 3 || !info[0]->IsFunction() ||
(info.Length() > 2 && (!info[2]->IsArray() && !info[2]->IsUndefined()))) {
On 2016/04/27 18:28:54, dgozman wrote:
> Let's make two early returns.

Done.

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h
(right):

https://codereview.chromium.org/1924713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h:21:
static v8::Local<v8::Object> create(V8DebuggerImpl*);
On 2016/04/27 18:28:54, dgozman wrote:
> Note that we expect that debugger outlives any JS context and thus
> V8InjectedScriptHost (owned by JS) is destroyed before debugger.

Done.

[pfeldman, 2016-04-27 20:49:57]

lgtm

[kozy, 2016-04-27 21:09:58]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-27 21:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1924713002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-27 21:10:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924713002/60001

[commit-bot: I haz the power, 2016-04-27 21:36:40]

Description was changed from

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction
method, we don't want to expose any errors from InjectedScript,
- cleanup V8InjectedScriptHost code.

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction
method, we don't want to expose any errors from InjectedScript,
- cleanup V8InjectedScriptHost code.

BUG=595206
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-04-27 21:36:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-30 17:13:26]

Patchset 4 (id:??) landed as
https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44
Cr-Commit-Position: refs/heads/master@{#390196}

[commit-bot: I haz the power, 2016-04-30 17:52:06]

Description was changed from

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction
method, we don't want to expose any errors from InjectedScript,
- cleanup V8InjectedScriptHost code.

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed InjectedScriptHost

- V8InjectedScriptHost become simple object,
- remove InjectedScriptHost,
- remove InspectorWrapper,
- remove callFunction method and replace it with suppressWarningsAndCallFunction
method, we don't want to expose any errors from InjectedScript,
- cleanup V8InjectedScriptHost code.

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/501509013f808ee9d45431b4c181233087a2ec44
Cr-Commit-Position: refs/heads/master@{#390196}
==========