Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1927703003: [DevTools] Remove bind from CommandLineAPI (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-injected-script-host
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove bind from CommandLineAPI Goal: remove bind from InjectedScriptSource.js. Next step: move remoteObjectAPI to native. BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/aa91e545b191fcaf2e84fce614c1dbf7b28d502e Cr-Commit-Position: refs/heads/master@{#390801}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -160 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 2 chunks +151 lines, -160 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1924713002 Patch 60001

Messages

Total messages: 11 (5 generated)
kozy
Dmitry, please take a look.
4 years, 7 months ago (2016-04-27 21:29:23 UTC) #1
kozy
ping!
4 years, 7 months ago (2016-04-29 17:32:00 UTC) #3
dgozman
lgtm, but please update description with a reason, as discussed offline.
4 years, 7 months ago (2016-04-29 21:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927703003/20001
4 years, 7 months ago (2016-04-29 22:20:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 23:29:50 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:30:05 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/aa91e545b191fcaf2e84fce614c1dbf7b28d502e
Cr-Commit-Position: refs/heads/master@{#390801}

Powered by Google App Engine
This is Rietveld 408576698