third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp - Issue 1924713002: [DevTools] Removed InjectedScriptHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 1924713002: [DevTools] Removed InjectedScriptHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-inspect-to-native

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

index c50c0f3723091c671d9b098121d719c9f5d55ae9..7a148a8fd529131a2c558d197efb75754f2136c8 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

@@ -5,7 +5,6 @@

#include "platform/v8_inspector/V8InspectorSessionImpl.h"

#include "platform/v8_inspector/InjectedScript.h"

-#include "platform/v8_inspector/InjectedScriptHost.h"

#include "platform/v8_inspector/InspectedContext.h"

#include "platform/v8_inspector/RemoteObjectId.h"

#include "platform/v8_inspector/V8DebuggerAgentImpl.h"

@@ -27,7 +26,6 @@ V8InspectorSessionImpl::V8InspectorSessionImpl(V8DebuggerImpl* debugger, int con

: m_contextGroupId(contextGroupId)

, m_debugger(debugger)

, m_client(nullptr)

- , m_injectedScriptHost(InjectedScriptHost::create(debugger))

, m_customObjectFormatterEnabled(false)

, m_instrumentationCounter(0)

, m_runtimeAgent(adoptPtr(new V8RuntimeAgentImpl(this)))

@@ -107,7 +105,7 @@ InjectedScript* V8InspectorSessionImpl::findInjectedScript(ErrorString* errorStr

InspectedContext* context = contexts->get(contextId);

if (!context->getInjectedScript()) {

- context->createInjectedScript(m_injectedScriptHost.get());

+ context->createInjectedScript();

if (!context->getInjectedScript()) {

*errorString = "Cannot access specified execution context";

return nullptr;