Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1921143002: [DevTools] Align Console implementation with The JSey way (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Align Console implementation with The JSey way window.console is a plain object with a bunch of function properties, similar to Window.Math. - console.prototype does not exist - console.__proto__ is Object.prototype Additionally all v8::FunctionTemplates were removed from v8_inspector. More details: https://github.com/whatwg/console/issues/3#issuecomment-214552839 BUG=167911 R=dgozman@chromium.org Committed: https://crrev.com/dcdc0218d3404fb53a1b27f40b3ebed5dd5e277d Cr-Commit-Position: refs/heads/master@{#390844}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Patch Set 4 : #

Messages

Total messages: 24 (12 generated)
kozy
Dmitry, please take a look.
4 years, 8 months ago (2016-04-26 00:07:32 UTC) #1
kozy
Let's land it. Please take a look.
4 years, 7 months ago (2016-04-29 19:25:56 UTC) #4
dgozman
lgtm
4 years, 7 months ago (2016-04-29 19:33:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921143002/40001
4 years, 7 months ago (2016-04-29 19:36:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/221494)
4 years, 7 months ago (2016-04-29 20:53:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921143002/40001
4 years, 7 months ago (2016-04-29 22:17:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/221605)
4 years, 7 months ago (2016-04-29 23:30:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921143002/40001
4 years, 7 months ago (2016-04-30 00:42:57 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/220333)
4 years, 7 months ago (2016-04-30 02:03:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921143002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921143002/60001
4 years, 7 months ago (2016-04-30 02:12:20 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-30 03:27:04 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:31:08 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dcdc0218d3404fb53a1b27f40b3ebed5dd5e277d
Cr-Commit-Position: refs/heads/master@{#390844}

Powered by Google App Engine
This is Rietveld 408576698