Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921413002: [DevTools] Move inspect and copy to native (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move inspect and copy to native BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75 Cr-Commit-Position: refs/heads/master@{#389987}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -108 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-command-copy.html View 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-command-copy-expected.txt View 1 chunk +9 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 2 chunks +34 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h View 1 3 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp View 2 chunks +3 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 3 chunks +1 line, -46 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 2 chunks +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1924713002 Patch 1
Issue 1924713002 Patch 20001
Issue 1924713002 Patch 40001
Issue 1924713002 Patch 60001

Messages

Total messages: 13 (5 generated)
kozy
Dmitry, please take a look. I'll replace InejctedScriptHost with Debugger in follow up.
4 years, 7 months ago (2016-04-26 23:44:14 UTC) #1
dgozman
lgtm! https://codereview.chromium.org/1921413002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right): https://codereview.chromium.org/1921413002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode288 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:288: if (subtype === "node") Can we use object.isNode()? ...
4 years, 7 months ago (2016-04-27 00:25:50 UTC) #2
kozy
https://codereview.chromium.org/1921413002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right): https://codereview.chromium.org/1921413002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode288 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:288: if (subtype === "node") On 2016/04/27 00:25:50, dgozman wrote: ...
4 years, 7 months ago (2016-04-27 01:22:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921413002/20001
4 years, 7 months ago (2016-04-27 01:23:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/128265)
4 years, 7 months ago (2016-04-27 01:28:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921413002/20001
4 years, 7 months ago (2016-04-27 01:31:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 03:56:17 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 03:58:45 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/45bae5d1a9a46e33e12ef3f09fddccb12ae4bd75
Cr-Commit-Position: refs/heads/master@{#389987}

Powered by Google App Engine
This is Rietveld 408576698