Switch the inheritance of WebViewClient from WebWidgetClient to protected.

Switch the inheritance of WebViewClient from WebWidgetClient to protected.

For now, all the methods used directly from WebViewClient are explicitly exposed in WebViewClient.

This is part of a long-term refactor to split WebView and WebWidget.

BUG=419087
Committed: https://crrev.com/2230bce6f2824a2dfae6506c8a9913ba71550bb1
Cr-Commit-Position: refs/heads/master@{#390429}

[lfg, 2016-04-27 21:25:02]

Description was changed from

==========
WIP
==========

to

==========
Switch the inheritance of WebViewClient from WebWidgetClient to protected.

For now, all the methods used directly from WebViewClient are explicitly exposed
in WebViewClient.

This is part of a long-term refactor to split WebView and WebWidget.

BUG=419087
==========

[lfg, 2016-04-27 21:27:22]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2016-04-27 21:27:23]

Daniel, please take a look.

[dcheng, 2016-04-27 23:55:04]

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:570: if
(WebLocalFrameImpl::fromFrame(frame) &&
WebLocalFrameImpl::fromFrame(frame)->frameWidget() &&
WebLocalFrameImpl::fromFrame(frame)->frameWidget()->forSubframe()) {
I previously tried to remove this and failed, because we didn't have a test web
widget client.

Maybe we can just remove this branching completely now?

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebViewClient.h (right):

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebViewClient.h:275: // WebWidgetClient interface.
Nit: WebWidgetClient overrides:

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebViewClient.h:309: WebWidgetClient*
widgetClientForTests() { return this; }
If this is just for tests, can we just expose it off TestWebViewClient and
require tests to use it?

This is similar to how we require the use of TestWebFrameClient for tests
already.

[lfg, 2016-04-28 16:08:19]

Patchset #2 (id:20001) has been deleted

[lfg, 2016-04-28 17:04:33]

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:570: if
(WebLocalFrameImpl::fromFrame(frame) &&
WebLocalFrameImpl::fromFrame(frame)->frameWidget() &&
WebLocalFrameImpl::fromFrame(frame)->frameWidget()->forSubframe()) {
On 2016/04/27 23:55:04, dcheng wrote:
> I previously tried to remove this and failed, because we didn't have a test
web
> widget client.
> 
> Maybe we can just remove this branching completely now?

I removed the branch but had to add a virtual to WebFrameWidget to get the
client. I think this should be acceptable until we can remove the
WebViewFrameWidget.

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebViewClient.h (right):

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebViewClient.h:275: // WebWidgetClient interface.
On 2016/04/27 23:55:04, dcheng wrote:
> Nit: WebWidgetClient overrides:

Done.

https://codereview.chromium.org/1924043002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebViewClient.h:309: WebWidgetClient*
widgetClientForTests() { return this; }
On 2016/04/27 23:55:04, dcheng wrote:
> If this is just for tests, can we just expose it off TestWebViewClient and
> require tests to use it?
> 
> This is similar to how we require the use of TestWebFrameClient for tests
> already.

Done. I've moved it to TestWebViewClient and renamed to widgetClient().

[dcheng, 2016-04-28 17:30:21]

lgtm

https://codereview.chromium.org/1924043002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1924043002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:571: if (client) {
Out of curiosity, does anyone actually pass a null client?

[lfg, 2016-04-28 17:43:57]

https://codereview.chromium.org/1924043002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1924043002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:571: if (client) {
On 2016/04/28 17:30:21, dcheng wrote:
> Out of curiosity, does anyone actually pass a null client?

I haven't checked, but this should never happen, since the localRoot should
always have a widget. I'll try to remove the null check and send a separate CL
for that.

[lfg, 2016-04-28 17:44:15]

lfg@chromium.org changed reviewers:
+ nick@chromium.org

[lfg, 2016-04-28 17:44:15]

nick@chromium.org: Please review changes in 

content/

[ncarter (slow), 2016-04-28 18:02:22]

lgtm

[lfg, 2016-04-28 18:30:31]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-04-28 18:31:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924043002/80001

[commit-bot: I haz the power, 2016-04-28 18:37:13]

Description was changed from

==========
Switch the inheritance of WebViewClient from WebWidgetClient to protected.

For now, all the methods used directly from WebViewClient are explicitly exposed
in WebViewClient.

This is part of a long-term refactor to split WebView and WebWidget.

BUG=419087
==========

to

==========
Switch the inheritance of WebViewClient from WebWidgetClient to protected.

For now, all the methods used directly from WebViewClient are explicitly exposed
in WebViewClient.

This is part of a long-term refactor to split WebView and WebWidget.

BUG=419087
==========

[commit-bot: I haz the power, 2016-04-28 18:37:15]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-04-30 17:19:47]

Patchset 4 (id:??) landed as
https://crrev.com/2230bce6f2824a2dfae6506c8a9913ba71550bb1
Cr-Commit-Position: refs/heads/master@{#390429}

[commit-bot: I haz the power, 2016-04-30 17:56:38]

Description was changed from

==========
Switch the inheritance of WebViewClient from WebWidgetClient to protected.

For now, all the methods used directly from WebViewClient are explicitly exposed
in WebViewClient.

This is part of a long-term refactor to split WebView and WebWidget.

BUG=419087
==========

to

==========
Switch the inheritance of WebViewClient from WebWidgetClient to protected.

For now, all the methods used directly from WebViewClient are explicitly exposed
in WebViewClient.

This is part of a long-term refactor to split WebView and WebWidget.

BUG=419087

Committed: https://crrev.com/2230bce6f2824a2dfae6506c8a9913ba71550bb1
Cr-Commit-Position: refs/heads/master@{#390429}
==========