third_party/WebKit/Source/web/tests/TopControlsTest.cpp - Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/TopControlsTest.cpp

Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, fix new test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.cpp ('K') | « third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp ('k') | third_party/WebKit/Source/web/tests/ViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/TopControlsTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

index faf99c2115e1bcbea0780ddba342896b0fe5ef4c..6fd0027a2c75eea545cce302e5405d34540de264 100644

--- a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

+++ b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

@@ -78,7 +78,7 @@ public:

// Load a page with large body and set viewport size to 400x400 to ensure

// main frame is scrollable.

- m_helper.initializeAndLoad(m_baseURL + pageName, true, 0, 0, &configureSettings);

+ m_helper.initializeAndLoad(m_baseURL + pageName, true, nullptr, nullptr, nullptr, &configureSettings);

webViewImpl()->resize(IntSize(400, 400));

return webViewImpl();