Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, fix new test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 312
313 // Most methods are handled by RenderWidget. 313 // Most methods are handled by RenderWidget.
314 void didFocus() override; 314 void didFocus() override;
315 void show(blink::WebNavigationPolicy policy) override; 315 void show(blink::WebNavigationPolicy policy) override;
316 bool requestPointerLock() override; 316 bool requestPointerLock() override;
317 void requestPointerUnlock() override; 317 void requestPointerUnlock() override;
318 bool isPointerLocked() override; 318 bool isPointerLocked() override;
319 void didHandleGestureEvent(const blink::WebGestureEvent& event, 319 void didHandleGestureEvent(const blink::WebGestureEvent& event,
320 bool event_cancelled) override; 320 bool event_cancelled) override;
321 void onMouseDown(const blink::WebNode& mouse_down_node) override; 321 void onMouseDown(const blink::WebNode& mouse_down_node) override;
322 void initializeLayerTreeView() override;
322 323
323 void initializeLayerTreeView() override; 324 // TODO(lfg): Remove once WebViewClient no longer inherits from
325 // WebWidgetClient.
326 bool allowsBrokenNullLayerTreeView() const override;
327 void closeWidgetSoon() override;
328 void convertViewportToWindow(blink::WebRect* rect) override;
329 void convertWindowToViewport(blink::WebFloatRect* rect) override;
330 void didAutoResize(const blink::WebSize& newSize) override;
331 void didChangeCursor(const blink::WebCursorInfo& info) override;
332 void didInvalidateRect(const blink::WebRect& rect) override;
333 void didMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;
334 void didOverscroll(const blink::WebFloatSize& overscrollDelta,
335 const blink::WebFloatSize& accumulatedOverscroll,
336 const blink::WebFloatPoint& positionInViewport,
337 const blink::WebFloatSize& velocityInViewport) override;
338 void didUpdateTextOfFocusedElementByNonUserInput() override;
339 void hasTouchEventHandlers(bool has_handlers) override;
340 blink::WebLayerTreeView* layerTreeView() override;
341 void resetInputMethod() override;
342 blink::WebRect rootWindowRect() override;
343 void scheduleAnimation() override;
344 blink::WebScreenInfo screenInfo() override;
345 void setToolTipText(const blink::WebString&,
346 blink::WebTextDirection hint) override;
347 void setTouchAction(blink::WebTouchAction touchAction) override;
348 void setWindowRect(const blink::WebRect& rect) override;
349 void showImeIfNeeded() override;
350 void showUnhandledTapUIIfNeeded(const blink::WebPoint& tappedPosition,
351 const blink::WebNode& tappedNode,
352 bool pageChanged) override;
353 blink::WebRect windowRect() override;
354 blink::WebRect windowResizerRect() override;
324 355
325 // blink::WebViewClient implementation -------------------------------------- 356 // blink::WebViewClient implementation --------------------------------------
326 357
327 blink::WebView* createView(blink::WebLocalFrame* creator, 358 blink::WebView* createView(blink::WebLocalFrame* creator,
328 const blink::WebURLRequest& request, 359 const blink::WebURLRequest& request,
329 const blink::WebWindowFeatures& features, 360 const blink::WebWindowFeatures& features,
330 const blink::WebString& frame_name, 361 const blink::WebString& frame_name,
331 blink::WebNavigationPolicy policy, 362 blink::WebNavigationPolicy policy,
332 bool suppress_opener) override; 363 bool suppress_opener) override;
333 blink::WebWidget* createPopupMenu(blink::WebPopupType popup_type) override; 364 blink::WebWidget* createPopupMenu(blink::WebPopupType popup_type) override;
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 // use the Observer interface to filter IPC messages and receive frame change 1015 // use the Observer interface to filter IPC messages and receive frame change
985 // notifications. 1016 // notifications.
986 // --------------------------------------------------------------------------- 1017 // ---------------------------------------------------------------------------
987 1018
988 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1019 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
989 }; 1020 };
990 1021
991 } // namespace content 1022 } // namespace content
992 1023
993 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1024 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698