Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: content/renderer/render_view_impl.h

Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, fix new test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index fe284de173b6420ee9cddcb673a9c87776f8333a..4c3d165671694994240dae2e0a58f55675ac24a9 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -319,9 +319,40 @@ class CONTENT_EXPORT RenderViewImpl
void didHandleGestureEvent(const blink::WebGestureEvent& event,
bool event_cancelled) override;
void onMouseDown(const blink::WebNode& mouse_down_node) override;
-
void initializeLayerTreeView() override;
+ // TODO(lfg): Remove once WebViewClient no longer inherits from
+ // WebWidgetClient.
+ bool allowsBrokenNullLayerTreeView() const override;
+ void closeWidgetSoon() override;
+ void convertViewportToWindow(blink::WebRect* rect) override;
+ void convertWindowToViewport(blink::WebFloatRect* rect) override;
+ void didAutoResize(const blink::WebSize& newSize) override;
+ void didChangeCursor(const blink::WebCursorInfo& info) override;
+ void didInvalidateRect(const blink::WebRect& rect) override;
+ void didMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;
+ void didOverscroll(const blink::WebFloatSize& overscrollDelta,
+ const blink::WebFloatSize& accumulatedOverscroll,
+ const blink::WebFloatPoint& positionInViewport,
+ const blink::WebFloatSize& velocityInViewport) override;
+ void didUpdateTextOfFocusedElementByNonUserInput() override;
+ void hasTouchEventHandlers(bool has_handlers) override;
+ blink::WebLayerTreeView* layerTreeView() override;
+ void resetInputMethod() override;
+ blink::WebRect rootWindowRect() override;
+ void scheduleAnimation() override;
+ blink::WebScreenInfo screenInfo() override;
+ void setToolTipText(const blink::WebString&,
+ blink::WebTextDirection hint) override;
+ void setTouchAction(blink::WebTouchAction touchAction) override;
+ void setWindowRect(const blink::WebRect& rect) override;
+ void showImeIfNeeded() override;
+ void showUnhandledTapUIIfNeeded(const blink::WebPoint& tappedPosition,
+ const blink::WebNode& tappedNode,
+ bool pageChanged) override;
+ blink::WebRect windowRect() override;
+ blink::WebRect windowResizerRect() override;
+
// blink::WebViewClient implementation --------------------------------------
blink::WebView* createView(blink::WebLocalFrame* creator,
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698