third_party/WebKit/public/web/WebFrameWidget.h - Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/web/WebFrameWidget.h

Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, fix new test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.cpp ('K') | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | third_party/WebKit/public/web/WebViewClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 // persists across subsequent navigations. Defaults to white prior to the	69 // persists across subsequent navigations. Defaults to white prior to the

70 // first call to this method.	70 // first call to this method.

71 virtual void setBaseBackgroundColor(WebColor) = 0;	71 virtual void setBaseBackgroundColor(WebColor) = 0;

72	72

73 // TODO(dcheng): Temporary: there should only be one WebFrameWidget	73 // TODO(dcheng): Temporary: there should only be one WebFrameWidget

74 // implementation but the Blink API is currently in a transition state.	74 // implementation but the Blink API is currently in a transition state.

75 // See https://goo.gl/7yVrnb. These methods should only be used inside	75 // See https://goo.gl/7yVrnb. These methods should only be used inside

76 // blink.	76 // blink.

77 virtual bool forSubframe() const { return true; }	77 virtual bool forSubframe() const { return true; }

78 virtual void scheduleAnimation() = 0;	78 virtual void scheduleAnimation() = 0;

	79 virtual WebWidgetClient* client() const = 0;

79 };	80 };

80	81

81 } // namespace blink	82 } // namespace blink

82	83

83 #endif	84 #endif

OLD	NEW