Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 1922223003: Change linesBoundingBox to return LayoutRect (Closed)

Created:
4 years, 8 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
drott, kojii
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change linesBoundingBox to return LayoutRect Change the LayoutInline::linesBoundingBox method, and subclass overrides in LayoutText and LayoutSVGInlineText, to return a LayoutRect instead of an IntRect. Thereby exposing more correct and consistent offsetWidth and offsetHeight values through the DOM. Move enclosing int logic to callers as needed, particularly for PaintLayer, editing, and spatial navigation. TEST=fast/sub-pixel/width-of-inline-in-float.html BUG=414264 R=drott@chromium.org Committed: https://crrev.com/bc1c2103ef7da6c61df91d2ee7dc1b00098a2b57 Cr-Commit-Position: refs/heads/master@{#390316}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/extend-to-line-boundary.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/sub-pixel/width-of-inline-in-float.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/sub-pixel/width-of-inline-in-float-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/ipa-tone-letters.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
eae
4 years, 7 months ago (2016-04-27 04:42:12 UTC) #4
eae
Can haz review please?
4 years, 7 months ago (2016-04-28 06:45:38 UTC) #8
kojii
lgtm
4 years, 7 months ago (2016-04-28 06:47:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922223003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922223003/100001
4 years, 7 months ago (2016-04-28 06:59:25 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 7 months ago (2016-04-28 07:03:45 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bc1c2103ef7da6c61df91d2ee7dc1b00098a2b57
Cr-Commit-Position: refs/heads/master@{#390316}

Powered by Google App Engine
This is Rietveld 408576698