Change linesBoundingBox to return LayoutRect

third_party/WebKit/Source/core/layout/LayoutInline.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 124 matching lines @@
     LayoutUnit marginStart(const ComputedStyle* otherStyle = nullptr) const final;
     LayoutUnit marginEnd(const ComputedStyle* otherStyle = nullptr) const final;
     LayoutUnit marginOver() const final;
     LayoutUnit marginUnder() const final;
 
     void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const final;
     void absoluteQuads(Vector<FloatQuad>&) const override;
 
     LayoutSize offsetFromContainer(const LayoutObject*) const final;
 
-    IntRect linesBoundingBox() const;
+    LayoutRect linesBoundingBox() const;
     LayoutRect visualOverflowRect() const final;
 
     InlineFlowBox* createAndAppendInlineFlowBox();
 
     void dirtyLineBoxes(bool fullLayout);
 
     LineBoxList* lineBoxes() { return &m_lineBoxes; }
     const LineBoxList* lineBoxes() const { return &m_lineBoxes; }
 
     InlineFlowBox* firstLineBox() const { return m_lineBoxes.firstLineBox(); }
@@ skipping 69 matching lines @@
     void layout() final { ASSERT_NOT_REACHED(); } // Do nothing for layout()
 
     void paint(const PaintInfo&, const LayoutPoint&) const final;
 
     bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;
 
     PaintLayerType layerTypeRequired() const override;
 
     LayoutUnit offsetLeft() const final;
     LayoutUnit offsetTop() const final;
-    LayoutUnit offsetWidth() const final { return LayoutUnit(linesBoundingBox().width()); }
-    LayoutUnit offsetHeight() const final { return LayoutUnit(linesBoundingBox().height()); }
+    LayoutUnit offsetWidth() const final { return linesBoundingBox().width(); }
+    LayoutUnit offsetHeight() const final { return linesBoundingBox().height(); }
 
     LayoutRect absoluteClippedOverflowRect() const override;
 
     // This method differs from visualOverflowRect in that it doesn't include the rects
     // for culled inline boxes, which aren't necessary for paint invalidation.
     LayoutRect localOverflowRectForPaintInvalidation() const override;
 
     bool mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ancestor, LayoutRect&, VisualRectFlags = DefaultVisualRectFlags) const final;
 
     PositionWithAffinity positionForPoint(const LayoutPoint&) final;
 
     IntRect borderBoundingBox() const final
     {
-        IntRect boundingBox = linesBoundingBox();
+        IntRect boundingBox = enclosingIntRect(linesBoundingBox());
         return IntRect(0, 0, boundingBox.width(), boundingBox.height());
     }
 
     virtual InlineFlowBox* createInlineFlowBox(); // Subclassed by SVG and Ruby
 
     void dirtyLinesFromChangedChild(LayoutObject* child) final { m_lineBoxes.dirtyLinesFromChangedChild(LineLayoutItem(this), LineLayoutItem(child)); }
 
     // TODO(leviw): This should probably be an int. We don't snap equivalent lines to different heights.
     LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const final;
     int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const final;
@@ skipping 14 matching lines @@
 
     LayoutObjectChildList m_children;
     LineBoxList m_lineBoxes; // All of the line boxes created for this inline flow.  For example, <i>Hello<br>world.</i> will have two <i> line boxes.
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutInline, isLayoutInline());
 
 } // namespace blink
 
 #endif // LayoutInline_h