Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.h

Issue 1922223003: Change linesBoundingBox to return LayoutRect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutInline.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.h b/third_party/WebKit/Source/core/layout/LayoutInline.h
index 1d936b1156419c753602b9dfe484e4528358e0b3..48628579d330ca3144ab7a08c837f1d785d254b1 100644
--- a/third_party/WebKit/Source/core/layout/LayoutInline.h
+++ b/third_party/WebKit/Source/core/layout/LayoutInline.h
@@ -142,7 +142,7 @@ public:
LayoutSize offsetFromContainer(const LayoutObject*) const final;
- IntRect linesBoundingBox() const;
+ LayoutRect linesBoundingBox() const;
LayoutRect visualOverflowRect() const final;
InlineFlowBox* createAndAppendInlineFlowBox();
@@ -232,8 +232,8 @@ private:
LayoutUnit offsetLeft() const final;
LayoutUnit offsetTop() const final;
- LayoutUnit offsetWidth() const final { return LayoutUnit(linesBoundingBox().width()); }
- LayoutUnit offsetHeight() const final { return LayoutUnit(linesBoundingBox().height()); }
+ LayoutUnit offsetWidth() const final { return linesBoundingBox().width(); }
+ LayoutUnit offsetHeight() const final { return linesBoundingBox().height(); }
LayoutRect absoluteClippedOverflowRect() const override;
@@ -247,7 +247,7 @@ private:
IntRect borderBoundingBox() const final
{
- IntRect boundingBox = linesBoundingBox();
+ IntRect boundingBox = enclosingIntRect(linesBoundingBox());
return IntRect(0, 0, boundingBox.width(), boundingBox.height());
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698