third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 1922223003: Change linesBoundingBox to return LayoutRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 1922223003: Change linesBoundingBox to return LayoutRect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index 5e86228f48fb302db78e693bf466c40359ae267e..9adde6003912b04d109af6a2501bc061312fb855 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -2159,7 +2159,7 @@ LayoutRect localCaretRectOfPosition(const PositionInFlatTreeWithAffinity& positi

return localCaretRectOfPositionTemplate<EditingInFlatTreeStrategy>(position, layoutObject);

}

-static int boundingBoxLogicalHeight(LayoutObject *o, const IntRect &rect)

+static LayoutUnit boundingBoxLogicalHeight(LayoutObject *o, const LayoutRect& rect)

{

return o->style()->isHorizontalWritingMode() ? rect.height() : rect.width();

}