third_party/WebKit/Source/core/dom/ContainerNode.cpp - Issue 1922223003: Change linesBoundingBox to return LayoutRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 1922223003: Change linesBoundingBox to return LayoutRect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ContainerNode.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.cpp b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

index 8099f739da783e31233d97e0eb49a6183b592a90..d2f6f61de2a20358f7308038db6dce98e5561523 100644

--- a/third_party/WebKit/Source/core/dom/ContainerNode.cpp

+++ b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

@@ -917,7 +917,7 @@ bool ContainerNode::getLowerRightCorner(FloatPoint& point) const

point = FloatPoint();

if (o->isText()) {

LayoutText* text = toLayoutText(o);

- IntRect linesBox = text->linesBoundingBox();

+ IntRect linesBox = enclosingIntRect(text->linesBoundingBox());

if (!linesBox.maxX() && !linesBox.maxY())

continue;

point.moveBy(linesBox.maxXMaxYCorner());