Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1921353002: Moves handful of files to ash/wm/common (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
James Cook, reveman
CC:
achuith+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dcheng, dzhioev+watch_chromium.org, extensions-reviews_chromium.org, kalyank, mlamouri+watch-notifications_chromium.org, oshima+watch_chromium.org, Peter Beverloo, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@shell_ids
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves handful of files to ash/wm/common These files are now ash and ui/aura/Window free. Also adds DEPS file to make sure don't add dependencies back. I didn't updated namespaces, will do that separately. BUG=603369 TEST=covered by tests R=jamescook@chromium.org TBR=reveman@chromium.org Committed: https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610 Cr-Commit-Position: refs/heads/master@{#389927}

Patch Set 1 #

Patch Set 2 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -4566 lines) Patch
M ash/accelerators/accelerator_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_commands_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 5 chunks +16 lines, -16 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/focus_cycler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/frame/default_header_painter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/frame_border_hit_test_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/shelf/background_animator.h View 1 chunk +0 lines, -72 lines 0 comments Download
D ash/shelf/background_animator.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_item_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/toplevel_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
A ash/wm/common/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A + ash/wm/common/background_animator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/background_animator.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
A + ash/wm/common/default_state.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/wm/common/default_state.cc View 1 10 chunks +36 lines, -35 lines 0 comments Download
A + ash/wm/common/dock/dock_types.h View 1 3 chunks +14 lines, -14 lines 0 comments Download
A + ash/wm/common/dock/docked_window_layout_manager.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + ash/wm/common/dock/docked_window_layout_manager.cc View 1 20 chunks +46 lines, -52 lines 0 comments Download
A + ash/wm/common/dock/docked_window_layout_manager_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/drag_details.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/drag_details.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
M ash/wm/common/shelf/wm_shelf_observer.h View 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/common/window_resizer.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ash/wm/common/window_resizer.cc View 1 14 chunks +28 lines, -37 lines 0 comments Download
A + ash/wm/common/window_state.h View 1 6 chunks +8 lines, -17 lines 0 comments Download
A + ash/wm/common/window_state.cc View 1 5 chunks +10 lines, -13 lines 0 comments Download
A + ash/wm/common/window_state_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/window_state_delegate.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
A + ash/wm/common/window_state_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/common/window_state_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ash/wm/default_state.h View 1 chunk +0 lines, -82 lines 0 comments Download
D ash/wm/default_state.cc View 1 chunk +0 lines, -735 lines 0 comments Download
M ash/wm/default_window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/default_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/dock/dock_types.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ash/wm/dock/docked_window_layout_manager.h View 1 chunk +0 lines, -315 lines 0 comments Download
D ash/wm/dock/docked_window_layout_manager.cc View 1 chunk +0 lines, -1334 lines 0 comments Download
D ash/wm/dock/docked_window_layout_manager_observer.h View 1 chunk +0 lines, -39 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ash/wm/drag_details.h View 1 chunk +0 lines, -71 lines 0 comments Download
D ash/wm/drag_details.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M ash/wm/drag_window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_window_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_window_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/mru_window_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/mru_window_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_handle_window_targeter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_handle_window_targeter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_shadow_and_cursor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_positioner.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_positioner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_properties.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/window_resizer.h View 1 chunk +0 lines, -111 lines 0 comments Download
D ash/wm/window_resizer.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D ash/wm/window_state.h View 1 chunk +0 lines, -396 lines 0 comments Download
D ash/wm/window_state.cc View 1 chunk +0 lines, -398 lines 0 comments Download
M ash/wm/window_state_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/window_state_delegate.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/wm/window_state_delegate.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/wm/window_state_observer.h View 1 chunk +0 lines, -40 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/window_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/fullscreen_notification_blocker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_ash.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/shell_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sky
Return of the ginormo patch (sorry). This is just a straight move. Only changes are ...
4 years, 8 months ago (2016-04-26 18:13:43 UTC) #3
James Cook
LGTM I sincerely hope you're using tools/git/move_source_file and not doing this by hand. :-)
4 years, 8 months ago (2016-04-26 18:33:20 UTC) #4
sky
Indeed. Doing this by hand would be a MAJOR PAIN! On Tue, Apr 26, 2016 ...
4 years, 8 months ago (2016-04-26 19:31:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921353002/20001
4 years, 8 months ago (2016-04-26 21:41:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 22:42:11 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610 Cr-Commit-Position: refs/heads/master@{#389927}
4 years, 8 months ago (2016-04-26 22:43:58 UTC) #12
reveman
4 years, 8 months ago (2016-04-27 00:30:50 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698