Split //ui/gl into //ui/gl + //ui/gi/init.

Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5b9dec1e9e9a86bf5d5c2acbbfc32597fac300a5
Cr-Commit-Position: refs/heads/master@{#393838}

[kylechar, 2016-04-28 14:29:37]

Description was changed from

==========
Split //ui/gl into //ui/gl + //ui/gl:gl_base.

Currently //ui/gl depends on //ui/ozone. This means that //ui/ozone
cannot create GLSurfaces or GLContexts. It has resulted in some very
awkward code to duplicate GLSurface functionality in //ui/ozone.
Splitting //ui/gl will allow each Ozone platform to create GLSurfaces
and GLContexts.

The new //ui/gl target only includes the factory functions to
initialize, create surfaces and create contexts. All other existing code
will be placed in //ui/gl:gl_base. The new //ui/gl target will have a
public_dep on //ui/gl_base making this change transparent in terms of
build targets.

The existing factory functions are static functions in GLSurface and
GLContext. These factory methods are moved to the new //ui/gl target.
Currently the new methods simply call the existing methods to avoid any
code changes. All callers of the factory functions are updated and the
existing functions are marked as DEPRECATED.

Subsequent CLs will move the implementation of factory functions from
//ui/gl to //ui/gl:gl_base and the static functions will be deleted.

Unfortunately there is no proper equivalent to public_deps for GYP. This
means that the new ui/gl/gl.gyp:gl_base target must be added to all
*.gyp/gypi files explicitly.

BUG=TBF
==========

to

==========
Split //ui/gl into //ui/gl + //ui/gl:gl_base.

Currently //ui/gl depends on //ui/ozone. This means that //ui/ozone
cannot create GLSurfaces or GLContexts. It has resulted in some very
awkward code to duplicate GLSurface functionality in //ui/ozone.
Splitting //ui/gl will allow each Ozone platform to create GLSurfaces
and GLContexts.

The new //ui/gl target only includes the factory functions to
initialize, create surfaces and create contexts. All other existing code
will be placed in //ui/gl:gl_base. The new //ui/gl target will have a
public_dep on //ui/gl_base making this change transparent in terms of
build targets.

The existing factory functions are static functions in GLSurface and
GLContext. These factory methods are moved to the new //ui/gl target.
Currently the new methods simply call the existing methods to avoid any
code changes. All callers of the factory functions are updated and the
existing functions are marked as DEPRECATED.

Subsequent CLs will move the implementation of factory functions from
//ui/gl to //ui/gl:gl_base and the static functions will be deleted.

Unfortunately there is no proper equivalent to public_deps for GYP. This
means that the new ui/gl/gl.gyp:gl_base target must be added to all
*.gyp/gypi files explicitly.

BUG=TBF
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-04-28 14:29:38]

Description was changed from

==========
Split //ui/gl into //ui/gl + //ui/gl:gl_base.

Currently //ui/gl depends on //ui/ozone. This means that //ui/ozone
cannot create GLSurfaces or GLContexts. It has resulted in some very
awkward code to duplicate GLSurface functionality in //ui/ozone.
Splitting //ui/gl will allow each Ozone platform to create GLSurfaces
and GLContexts.

The new //ui/gl target only includes the factory functions to
initialize, create surfaces and create contexts. All other existing code
will be placed in //ui/gl:gl_base. The new //ui/gl target will have a
public_dep on //ui/gl_base making this change transparent in terms of
build targets.

The existing factory functions are static functions in GLSurface and
GLContext. These factory methods are moved to the new //ui/gl target.
Currently the new methods simply call the existing methods to avoid any
code changes. All callers of the factory functions are updated and the
existing functions are marked as DEPRECATED.

Subsequent CLs will move the implementation of factory functions from
//ui/gl to //ui/gl:gl_base and the static functions will be deleted.

Unfortunately there is no proper equivalent to public_deps for GYP. This
means that the new ui/gl/gl.gyp:gl_base target must be added to all
*.gyp/gypi files explicitly.

BUG=TBF
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split //ui/gl into //ui/gl + //ui/gl:gl_base.

Currently //ui/gl depends on //ui/ozone. This means that //ui/ozone
cannot create GLSurfaces or GLContexts. It has resulted in some very
awkward code to duplicate GLSurface functionality in //ui/ozone.
Splitting //ui/gl will allow each Ozone platform to create GLSurfaces
and GLContexts.

The new //ui/gl target only includes the factory functions to
initialize, create surfaces and create contexts. All other existing code
will be placed in //ui/gl:gl_base. The new //ui/gl target will have a
public_dep on //ui/gl_base making this change transparent in terms of
build targets.

The existing factory functions are static functions in GLSurface and
GLContext. These factory methods are moved to the new //ui/gl target.
Currently the new methods simply call the existing methods to avoid any
code changes. All callers of the factory functions are updated and the
existing functions are marked as DEPRECATED.

Subsequent CLs will move the implementation of factory functions from
//ui/gl to //ui/gl:gl_base and the static functions will be deleted.

Unfortunately there is no proper equivalent to public_deps for GYP. This
means that the new ui/gl/gl.gyp:gl_base target must be added to all
*.gyp/gypi files explicitly.

BUG=TBF
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[kylechar, 2016-05-03 15:58:29]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 15:59:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920163005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920163005/60001

[commit-bot: I haz the power, 2016-05-03 16:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 16:18:54]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[kylechar, 2016-05-04 17:15:47]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 17:16:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920163005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920163005/100001

[commit-bot: I haz the power, 2016-05-04 19:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 19:04:27]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-05-11 17:53:27]

Patchset #7 (id:120001) has been deleted

[kylechar, 2016-05-11 17:53:46]

Patchset #7 (id:140001) has been deleted

[kylechar, 2016-05-11 17:54:12]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 17:54:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920163005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920163005/160001

[kylechar, 2016-05-11 18:52:14]

Description was changed from

==========
Split //ui/gl into //ui/gl + //ui/gl:gl_base.

Currently //ui/gl depends on //ui/ozone. This means that //ui/ozone
cannot create GLSurfaces or GLContexts. It has resulted in some very
awkward code to duplicate GLSurface functionality in //ui/ozone.
Splitting //ui/gl will allow each Ozone platform to create GLSurfaces
and GLContexts.

The new //ui/gl target only includes the factory functions to
initialize, create surfaces and create contexts. All other existing code
will be placed in //ui/gl:gl_base. The new //ui/gl target will have a
public_dep on //ui/gl_base making this change transparent in terms of
build targets.

The existing factory functions are static functions in GLSurface and
GLContext. These factory methods are moved to the new //ui/gl target.
Currently the new methods simply call the existing methods to avoid any
code changes. All callers of the factory functions are updated and the
existing functions are marked as DEPRECATED.

Subsequent CLs will move the implementation of factory functions from
//ui/gl to //ui/gl:gl_base and the static functions will be deleted.

Unfortunately there is no proper equivalent to public_deps for GYP. This
means that the new ui/gl/gl.gyp:gl_base target must be added to all
*.gyp/gypi files explicitly.

BUG=TBF
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the relevant bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-11 22:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 22:27:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kylechar, 2016-05-11 22:30:32]

kylechar@chromium.org changed reviewers:
+ piman@chromium.org

[kylechar, 2016-05-11 23:13:22]

Description was changed from

==========
Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the relevant bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[piman, 2016-05-11 23:14:57]

lgtm

https://codereview.chromium.org/1920163005/diff/160001/android_webview/browse...
File android_webview/browser/aw_gl_surface.h (right):

https://codereview.chromium.org/1920163005/diff/160001/android_webview/browse...
android_webview/browser/aw_gl_surface.h:17: class GL_EXPORT AwGLSurface : public
gfx::GLSurface {
huh... I don't think this should be GL_EXPORT, it's not part of the gl component

[rjkroege, 2016-05-11 23:58:29]

rjkroege@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-05-11 23:58:30]

fwiw ui/ozone lgtm

[Pawel Osciak, 2016-05-12 00:04:40]

posciak@chromium.org changed reviewers:
+ posciak@chromium.org

[Pawel Osciak, 2016-05-12 00:04:41]

media/gpu lgtm

[kylechar, 2016-05-12 14:38:57]

Patchset #8 (id:180001) has been deleted

[kylechar, 2016-05-12 14:47:29]

kylechar@chromium.org changed reviewers:
+ nyquist@chromium.org, sadrul@chromium.org, sgurun@chromium.org,
wolenetz@chromium.org

[kylechar, 2016-05-12 14:47:30]

Thanks! Adding sgurun for android_webview/*, wolenetz for media/media_gpu.gypi
and sadrul for remaining ui/*.

https://codereview.chromium.org/1920163005/diff/160001/android_webview/browse...
File android_webview/browser/aw_gl_surface.h (right):

https://codereview.chromium.org/1920163005/diff/160001/android_webview/browse...
android_webview/browser/aw_gl_surface.h:17: class GL_EXPORT AwGLSurface : public
gfx::GLSurface {
On 2016/05/11 23:14:57, piman wrote:
> huh... I don't think this should be GL_EXPORT, it's not part of the gl
component

Yeah, this doesn't seem right at all looking at it closer. I'll remove the
include and macro.

[nyquist, 2016-05-12 18:03:07]

blimp lgtm

[wolenetz, 2016-05-12 20:12:50]

wolenetz@chromium.org changed reviewers:
+ watk@chromium.org

[wolenetz, 2016-05-12 20:12:52]

Over to watk@ for media/media_gpu.gypi CR

[wolenetz, 2016-05-12 20:13:23]

wolenetz@chromium.org changed reviewers:
- wolenetz@chromium.org

[watk, 2016-05-12 20:19:44]

media/media_gpu.gypi lgtm

[sgurun-gerrit only, 2016-05-12 23:13:39]

lgtm

[sadrul, 2016-05-13 16:26:27]

lgtm

[kylechar, 2016-05-13 17:45:43]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-05-13 17:45:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, posciak@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1920163005/#ps200001
(title: "Rebase/fix for comment.")

[commit-bot: I haz the power, 2016-05-13 17:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920163005/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920163005/200001

[commit-bot: I haz the power, 2016-05-13 22:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 22:59:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kylechar, 2016-05-16 14:08:34]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-05-16 14:08:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, sgurun@chromium.org, sadrul@chromium.org,
watk@chromium.org, piman@chromium.org, nyquist@chromium.org,
posciak@chromium.org
Link to the patchset: https://codereview.chromium.org/1920163005/#ps220001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-05-16 14:08:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920163005/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920163005/220001

[commit-bot: I haz the power, 2016-05-16 15:41:07]

Description was changed from

==========
Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-16 15:41:09]

Committed patchset #9 (id:220001)

[commit-bot: I haz the power, 2016-05-16 15:42:45]

Description was changed from

==========
Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Split //ui/gl into //ui/gl + //ui/gi/init.

Refactor //ui/gl to fix Ozone dep problem. This CL is step 1 described
in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5b9dec1e9e9a86bf5d5c2acbbfc32597fac300a5
Cr-Commit-Position: refs/heads/master@{#393838}
==========

[commit-bot: I haz the power, 2016-05-16 15:42:47]

Patchset 9 (id:??) landed as
https://crrev.com/5b9dec1e9e9a86bf5d5c2acbbfc32597fac300a5
Cr-Commit-Position: refs/heads/master@{#393838}