Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1919143002: Store constant variable initializers in elements. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -69 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 5 chunks +6 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/inline.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 2 chunks +13 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization_test_helper.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-26 12:56:22 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1919143002/diff/1/pkg/compiler/lib/src/elements/elements.dart File pkg/compiler/lib/src/elements/elements.dart (right): https://codereview.chromium.org/1919143002/diff/1/pkg/compiler/lib/src/elements/elements.dart#newcode1002 pkg/compiler/lib/src/elements/elements.dart:1002: /// [ErroneousConstantExpression], other otherwise the value is null ...
4 years, 8 months ago (2016-04-27 05:52:40 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as d1ca90aba661b62df3cf70e8cf662065ce5550be (presubmit successful).
4 years, 8 months ago (2016-04-27 08:02:18 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-04-28 09:11:01 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1919143002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/1919143002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:1002: ///
[ErroneousConstantExpression], other otherwise the value is null the
On 2016/04/27 05:52:39, Siggi Cherem (dart-lang) wrote:
> nit: rephrase (other otherwise => otherwise, null the => null when the?)

Done.

Powered by Google App Engine
This is Rietveld 408576698