pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 1919143002: Store constant variable initializers in elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 1919143002: Store constant variable initializers in elements. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart ('k') | pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index 145070f9cba1709f7e69897daaf8e965c86ad9ae..da33e20a879efdc0181f2ecbe62fe2a23b419979 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -690,14 +690,14 @@ class ProgramBuilder {

optionalParameterDefaultValues = new Map<String, ConstantValue>();

signature.forEachOptionalParameter((ParameterElement parameter) {

ConstantValue def =

- backend.constants.getConstantValueForVariable(parameter);

+ backend.constants.getConstantValue(parameter.constant);

optionalParameterDefaultValues[parameter.name] = def;

});

} else {

optionalParameterDefaultValues = <ConstantValue>[];

signature.forEachOptionalParameter((ParameterElement parameter) {

ConstantValue def =

- backend.constants.getConstantValueForVariable(parameter);

+ backend.constants.getConstantValue(parameter.constant);

optionalParameterDefaultValues.add(def);

});

}