pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart - Issue 1919143002: Store constant variable initializers in elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

Issue 1919143002: Store constant variable initializers in elements. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

diff --git a/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart b/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

index b148b11e8cff04ce64fd0459246c439f89cebb9c..d13b1241f712c8c9056576141c06ec8234573f03 100644

--- a/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

+++ b/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

@@ -1299,8 +1299,9 @@ class SimpleTypeInferrerVisitor<T>

element.isField &&

Elements.isStaticOrTopLevelField(element) &&

compiler.world.fieldNeverChanges(element)) {

+ FieldElement fieldElement = element;

ConstantValue value =

- compiler.backend.constants.getConstantValueForVariable(element);

+ compiler.backend.constants.getConstantValue(fieldElement.constant);

if (value != null && value.isInt) {

IntConstantValue intValue = value;

return intValue.primitiveValue;