pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart - Issue 1919143002: Store constant variable initializers in elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

Issue 1919143002: Store constant variable initializers in elements. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

diff --git a/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

index 88ffbf917a737d1d336e77e382f94de894bc7162..82785255d8fa3c8794de5a1e7777821b26d83a8d 100644

--- a/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

+++ b/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

@@ -190,8 +190,7 @@ class Dart2JsParameterMirror extends Dart2JsMemberMirror

// TODO(johnniwinther): Get the constant from the [TreeElements]

// associated with the enclosing method.

ParameterElement parameter = _element;

- ConstantExpression constant =

- mirrorSystem.compiler.constants.getConstantForVariable(parameter);

+ ConstantExpression constant = parameter.constant;

assert(invariant(parameter, constant != null,

message: "Missing constant for parameter "

"$parameter with default value."));