pkg/compiler/lib/src/js_backend/backend.dart - Issue 1919143002: Store constant variable initializers in elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 1919143002: Store constant variable initializers in elements. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/backend.dart

diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart

index a7d67ddae81557e377bf87e4ff3c8068ed61cfeb..90cd7ce8b0d14e705b600f8ad31ff878dadba95f 100644

--- a/pkg/compiler/lib/src/js_backend/backend.dart

+++ b/pkg/compiler/lib/src/js_backend/backend.dart

@@ -1463,8 +1463,9 @@ class JavaScriptBackend extends Backend {

return const CodegenImpact();

}

if (kind.category == ElementCategory.VARIABLE) {

+ VariableElement variableElement = element;

ConstantValue initialValue =

- constants.getConstantValueForVariable(element);

+ constants.getConstantValue(variableElement.constant);

if (initialValue != null) {

registerCompileTimeConstant(initialValue, work.registry);

addCompileTimeConstantForEmission(initialValue);