Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 19183003: path ops near exact (Closed)

Created:
7 years, 5 months ago by caryclark
Modified:
7 years, 5 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

path ops near exact Modify line intersections to first - match exact ends - compute intersections - match near ends where the exact ends are preferred, then near matches, then computed matches. This pulls matches towards existing end points when possible, and keeps intersection distances consistent with different line/line line/quad and line/cubic computations. BUG= Committed: https://code.google.com/p/skia/source/detail?r=10073

Patch Set 1 #

Patch Set 2 : fix debug errors #

Patch Set 3 : remove unused static function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+783 lines, -284 lines) Patch
M src/pathops/SkDCubicIntersection.cpp View 3 chunks +13 lines, -10 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 10 chunks +71 lines, -39 lines 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 1 2 2 chunks +131 lines, -127 lines 0 comments Download
M src/pathops/SkDQuadIntersection.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/pathops/SkDQuadLineIntersection.cpp View 12 chunks +75 lines, -53 lines 0 comments Download
M src/pathops/SkIntersections.h View 6 chunks +11 lines, -9 lines 0 comments Download
M src/pathops/SkIntersections.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 chunks +81 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsLine.h View 1 chunk +12 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsLine.cpp View 1 chunk +91 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 3 chunks +19 lines, -2 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 4 chunks +39 lines, -6 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 3 chunks +6 lines, -2 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 3 chunks +53 lines, -6 lines 0 comments Download
M tests/PathOpsLineParametetersTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpCubicThreadedTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +107 lines, -0 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionTest.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
caryclark
7 years, 5 months ago (2013-07-15 13:29:34 UTC) #1
Message was sent while issue was closed.
Committed patchset #3 manually as r10073 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698