Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915153004: [K5] Replace bind() + non-GC pointers with unretained() (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, Mads Ager (chromium), Peter Beverloo, sof, jbroman, loading-reviews_chromium.org, krit, haraken, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, scheduler-bugs_chromium.org, falken, f(malita), oilpan-reviews, horo+watch_chromium.org, danakj+watch_chromium.org, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[K5] Disallow non-GC raw pointers in bind() and replace them with unretained() BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -40 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1925583003 Patch 20001

Dependent Patchsets:

Issue 1920193002 Patch 40001

Messages

Total messages: 1 (1 generated)
hiroshige
4 years, 8 months ago (2016-04-26 11:44:50 UTC) #1 
Description was changed from

==========
[K5] Disallow non-GC raw pointers in bind() and replace them with unretained()

BUG=
==========

to

==========
[K5] Disallow non-GC raw pointers in bind() and replace them with unretained()

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698