Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1920193002: Remove CrossThreadCopier for WeakMember and WeakMember* (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CrossThreadCopier for WeakMember and WeakMember* - They are not used. - When they are used, persistent (not weak) references are kept in WTF::Function, which might be confusing. BUG=597856 Committed: https://crrev.com/7243fbfa8ddce432569b59a16126f3511a4cd808 Cr-Commit-Position: refs/heads/master@{#390371}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 3 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920193002/20001
4 years, 7 months ago (2016-04-27 04:46:45 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/128386)
4 years, 7 months ago (2016-04-27 05:04:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920193002/20001
4 years, 7 months ago (2016-04-28 05:36:18 UTC) #6
hiroshige
PTAL.
4 years, 7 months ago (2016-04-28 06:37:54 UTC) #9
haraken
LGTM
4 years, 7 months ago (2016-04-28 07:39:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920193002/60001
4 years, 7 months ago (2016-04-28 10:15:06 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-28 14:19:10 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:18:14 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7243fbfa8ddce432569b59a16126f3511a4cd808
Cr-Commit-Position: refs/heads/master@{#390371}

Powered by Google App Engine
This is Rietveld 408576698