third_party/WebKit/Source/platform/heap/Handle.h - Issue 1915153004: [K5] Replace bind() + non-GC pointers with unretained()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Handle.h

Issue 1915153004: [K5] Replace bind() + non-GC pointers with unretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp ('k') | third_party/WebKit/Source/platform/heap/HeapTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/Handle.h

diff --git a/third_party/WebKit/Source/platform/heap/Handle.h b/third_party/WebKit/Source/platform/heap/Handle.h

index 5bb461a398bcc347679e630bb0eca854d258488d..de696ee02b3af5499264691fb6c09c4a2e512a42 100644

--- a/third_party/WebKit/Source/platform/heap/Handle.h

+++ b/third_party/WebKit/Source/platform/heap/Handle.h

@@ -1196,15 +1196,6 @@ template<typename T, bool isGarbageCollected> struct PointerParamStorageTraits;

// The condition of 'T must be fully defined' (except for void) is checked in

// blink::IsGarbageCollectedType<T>::value.

template<typename T>

-struct PointerParamStorageTraits<T*, false> {

- STATIC_ONLY(PointerParamStorageTraits);

- using StorageType = T*;

- static StorageType wrap(T* value) { return value; }

- static T* unwrap(const StorageType& value) { return value; }

-};

-template<typename T>

struct PointerParamStorageTraits<T*, true> {

STATIC_ONLY(PointerParamStorageTraits);

using StorageType = blink::CrossThreadPersistent<T>;