third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp - Issue 1915153004: [K5] Replace bind() + non-GC pointers with unretained()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp

Issue 1915153004: [K5] Replace bind() + non-GC pointers with unretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp b/third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp

index f650884903c0e05d77a440ae135b39cfef152a2d..f620461facf381d8ce07095697e0a94840fe5e87 100644

--- a/third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp

+++ b/third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp

@@ -49,7 +49,7 @@ TEST(MainThreadTaskRunnerTest, PostTask)

MainThreadTaskRunner* runner = MainThreadTaskRunner::create(context);

bool isMarked = false;

- runner->postTask(BLINK_FROM_HERE, createSameThreadTask(&markBoolean, &isMarked));

+ runner->postTask(BLINK_FROM_HERE, createSameThreadTask(&markBoolean, unretained(&isMarked)));

EXPECT_FALSE(isMarked);

blink::testing::runPendingTasks();

EXPECT_TRUE(isMarked);

@@ -62,7 +62,7 @@ TEST(MainThreadTaskRunnerTest, SuspendTask)

bool isMarked = false;

context->setTasksNeedSuspension(true);

- runner->postTask(BLINK_FROM_HERE, createSameThreadTask(&markBoolean, &isMarked));

+ runner->postTask(BLINK_FROM_HERE, createSameThreadTask(&markBoolean, unretained(&isMarked)));

runner->suspend();

blink::testing::runPendingTasks();

EXPECT_FALSE(isMarked);

@@ -80,7 +80,7 @@ TEST(MainThreadTaskRunnerTest, RemoveRunner)

bool isMarked = false;

context->setTasksNeedSuspension(true);

- runner->postTask(BLINK_FROM_HERE, createSameThreadTask(&markBoolean, &isMarked));

+ runner->postTask(BLINK_FROM_HERE, createSameThreadTask(&markBoolean, unretained(&isMarked)));

runner = nullptr;

blink::testing::runPendingTasks();

EXPECT_FALSE(isMarked);