third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp - Issue 1915153004: [K5] Replace bind() + non-GC pointers with unretained()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

Issue 1915153004: [K5] Replace bind() + non-GC pointers with unretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

diff --git a/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp b/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

index 2a6f271c004709f3ca84a15e11c686216cd38b08..b366d19c0f8ec7ba6d30e0a18f6afa51cfb73150 100644

--- a/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

+++ b/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

@@ -119,12 +119,12 @@ protected:

void addObserverOnNotification(StateObserver* observer, StateObserver* observerToAdd)

{

- observer->setNotificationCallback(bind(&NetworkStateNotifier::addObserver, &m_notifier, observerToAdd, getExecutionContext()));

+ observer->setNotificationCallback(bind(&NetworkStateNotifier::addObserver, unretained(&m_notifier), unretained(observerToAdd), getExecutionContext()));

}

void removeObserverOnNotification(StateObserver* observer, StateObserver* observerToRemove)

{

- observer->setNotificationCallback(bind(&NetworkStateNotifier::removeObserver, &m_notifier, observerToRemove, getExecutionContext()));

+ observer->setNotificationCallback(bind(&NetworkStateNotifier::removeObserver, unretained(&m_notifier), unretained(observerToRemove), getExecutionContext()));

}

bool verifyObservations(const StateObserver& observer, WebConnectionType type, double maxBandwidthMbps)