Refactors DockedWindowLayoutManager in terms of ash/wm/common

Refactors DockedWindowLayoutManager in terms of ash/wm/common

Last remaining bit is shell ids.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc
Cr-Commit-Position: refs/heads/master@{#389852}

[sky, 2016-04-26 03:15:28]

Sorry for the size. In the future I'll keep namepsace changes to their own
dedicated patches.

[James Cook, 2016-04-26 15:22:34]

LGTM with nits

https://codereview.chromium.org/1914093002/diff/80001/ash/shelf/shelf.cc
File ash/shelf/shelf.cc (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/shelf/shelf.cc#newc...
ash/shelf/shelf.cc:53: wm_shelf_.reset(new wm::WmShelfAura(this));
optional: Maybe comment why this has to be done at the end? I presume it's
because the shelf layout manager is initialized as one of the steps above.

https://codereview.chromium.org/1914093002/diff/80001/ash/system/status_area_...
File ash/system/status_area_widget_delegate.cc (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/system/status_area_...
ash/system/status_area_widget_delegate.cc:52: : focus_cycler_for_testing_(NULL),
alignment_(wm::SHELF_ALIGNMENT_BOTTOM) {
nullptr while you're here

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/aura/wm_shelf_au...
File ash/wm/aura/wm_shelf_aura.h (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/aura/wm_shelf_au...
ash/wm/aura/wm_shelf_aura.h:21: class ASH_EXPORT WmShelfAura : public WmShelf,
nit: Class comment please

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
File ash/wm/common/shelf/wm_shelf_constants.h (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
ash/wm/common/shelf/wm_shelf_constants.h:14: ASH_EXPORT extern const int
kShelfBackgroundAlpha;
I know you just moved these from elsewhere, but do they need to be ASH_EXPORT? I
don't see them used outside src/ash. If not, do they need to be extern?

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
File ash/wm/common/shelf/wm_shelf_observer.h (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
ash/wm/common/shelf/wm_shelf_observer.h:18: // Used to changes to the shelf.
nit: "Used to" -> "Used for". Or just delete comment.

[sky, 2016-04-26 16:26:02]

https://codereview.chromium.org/1914093002/diff/80001/ash/shelf/shelf.cc
File ash/shelf/shelf.cc (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/shelf/shelf.cc#newc...
ash/shelf/shelf.cc:53: wm_shelf_.reset(new wm::WmShelfAura(this));
On 2016/04/26 15:22:34, James Cook wrote:
> optional: Maybe comment why this has to be done at the end? I presume it's
> because the shelf layout manager is initialized as one of the steps above.

Done.

https://codereview.chromium.org/1914093002/diff/80001/ash/system/status_area_...
File ash/system/status_area_widget_delegate.cc (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/system/status_area_...
ash/system/status_area_widget_delegate.cc:52: : focus_cycler_for_testing_(NULL),
alignment_(wm::SHELF_ALIGNMENT_BOTTOM) {
On 2016/04/26 15:22:34, James Cook wrote:
> nullptr while you're here

Done.

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/aura/wm_shelf_au...
File ash/wm/aura/wm_shelf_aura.h (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/aura/wm_shelf_au...
ash/wm/aura/wm_shelf_aura.h:21: class ASH_EXPORT WmShelfAura : public WmShelf,
On 2016/04/26 15:22:34, James Cook wrote:
> nit: Class comment please

Done.

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
File ash/wm/common/shelf/wm_shelf_constants.h (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
ash/wm/common/shelf/wm_shelf_constants.h:14: ASH_EXPORT extern const int
kShelfBackgroundAlpha;
On 2016/04/26 15:22:34, James Cook wrote:
> I know you just moved these from elsewhere, but do they need to be ASH_EXPORT?
I
> don't see them used outside src/ash. If not, do they need to be extern?

At this point I think you're right. But soonish ash/wm/common is going to be
it's own dll, which it's own export. So, I'm going to leave it like this to make
the search/replace easier.

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
File ash/wm/common/shelf/wm_shelf_observer.h (right):

https://codereview.chromium.org/1914093002/diff/80001/ash/wm/common/shelf/wm_...
ash/wm/common/shelf/wm_shelf_observer.h:18: // Used to changes to the shelf.
On 2016/04/26 15:22:34, James Cook wrote:
> nit: "Used to" -> "Used for". Or just delete comment.

Done.

[sky, 2016-04-26 16:26:44]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-26 16:26:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/1914093002/#ps100001
(title: "feedback")

[commit-bot: I haz the power, 2016-04-26 16:26:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914093002/100001

[sky, 2016-04-26 17:23:19]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-26 17:23:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/1914093002/#ps120001
(title: "comment")

[commit-bot: I haz the power, 2016-04-26 17:23:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914093002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914093002/120001

[commit-bot: I haz the power, 2016-04-26 19:41:10]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-26 19:42:46]

Description was changed from

==========
Refactors DockedWindowLayoutManager in terms of ash/wm/common

Last remaining bit is shell ids.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Refactors DockedWindowLayoutManager in terms of ash/wm/common

Last remaining bit is shell ids.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc
Cr-Commit-Position: refs/heads/master@{#389852}
==========

[commit-bot: I haz the power, 2016-04-26 19:42:48]

Patchset 7 (id:??) landed as
https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc
Cr-Commit-Position: refs/heads/master@{#389852}