Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1920153003: Starts splitting out shell window ids (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@prune_docked_layout_deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Starts splitting out shell window ids BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/b856eb2b11c1894a1240a7026414b1a3800606d7 Cr-Commit-Position: refs/heads/master@{#389884}

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M ash/shell_window_ids.h View 2 chunks +12 lines, -2 lines 0 comments Download
A ash/wm/common/wm_shell_window_ids.h View 1 chunk +20 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
Finally a small patch!
4 years, 7 months ago (2016-04-26 17:28:13 UTC) #1
James Cook
lgtm
4 years, 7 months ago (2016-04-26 17:47:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920153003/20001
4 years, 7 months ago (2016-04-26 20:03:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-26 21:13:45 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 21:15:07 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b856eb2b11c1894a1240a7026414b1a3800606d7
Cr-Commit-Position: refs/heads/master@{#389884}

Powered by Google App Engine
This is Rietveld 408576698